Erroneous planned date in the future on incoming moves can't be updated on supplier shipment

added type::feature label and removed type::behavior label

Indeed this was added by fcc64f705f83. But I think the main problem is that supplier shipment has a planned date set to today by default. So user may create supplier shipment without a correct planned date and thus change the planned date of all the stock moves selected.

I think we could remove this constraint and just always update the planned date of incoming moves if we do not set a default planned date on the supplier shipment. And of course when there is no planned date, the planned date of incoming moves are not modified. This way the planned date of the incoming moves are only updated if the user set explicitly a planned date for the supplier shipment.

assigned to @maxx

Is it allowed to have a planned date in the past ? Or it should be >= Today.

It is always a problem to make constraint based on time.

I made a check before writing moves.

I do not think it is any way good, because if I set the planned date to today, it will become invalid tomorrow. So I can not redo the same action. For me such constraint does not help nor solve any problem, it just create friction on usage.

Indeed, I could remove the test. But, even if there's no check, if you define a planned date for today then tomorrow, you'll have to update the planned date in any case if you don't want an outdated supplier shipment. My test just prevents to write moves in the past if you set an erroneous planned date.

mentioned in commit c6834f41b034

mentioned in merge request !1331 (merged)

mentioned in commit 7ce2875fbcb8

mentioned in commit e644e3d68b1f

mentioned in commit 61b29ed6633b

mentioned in commit 6b9d9ac25d66

mentioned in commit 0f501556fbcb

closed with merge request !1331 (merged)

Erroneous planned date in the future on incoming moves can't be updated on supplier shipment

Child items 0

Activity