Message 67103

Author
nicoe
Date
2021-04-30.09:08:10
Message id
67103

Content

* C├ędric Krier  [2021-04-30 00:14 +0200]: 

>For me it is a complex code to maintain for 

I could understand the argument of the complexity for the javascript version
(because of the margin, the usage of "getBoundingRect" which is not exactly
self-explanatory) but the GTK one is not really complex.

But something even more simple could use the height of the screen.

>no real guarantee to be correct

It is best effort, there's no point in determining exactly the right number of
rows as long as you're a bit but not too much above the number of displayed
rows.

Which I think happen when we using the menu as a base because it has no
buttons, search bar, etc and so the dividend is greater than it would be for
the usual tree view with the search. 

>and for almost no benefit compared to a fixed minimal value based on common
>screen sizes

I don't think there is such a thing as a "common screen size". Even more so if
we take into account the web and the different handheld terminals people could
use there.

According to https://www.w3schools.com/browsers/browsers_display.asp the
resolutions of the screen of people browsing their website are:

- Other high resolutions: 52.2%
- 1366x768: 24.8%
- 1920x1080: 19.2%
- Lower: 10.7%

(I would have bet that 1920x1080 was the biggest something like 60%, I am far
from the truth. It's a bit sad that wikipedia or google do not make their data
about this available as they are more mainstream).

>(which could even be a configuration parameter if needed).

Why not but it seems a bit too technical to explain to the users.
History
Date User Action Args
2021-04-30 09:08:13nicoesetrecipients: + ced, pokoli, reviewbot
2021-04-30 09:08:13nicoelinkissue10043 messages
2021-04-30 09:08:10nicoecreate

Showing 10 items. Show all history (warning: this could be VERY long)