> Usually we have getter method with the same name as the function field, so get_payments_info would be named get_amount.
I used this name because the same function was used for getter of count, amount, amount_succeeded, complete. I renamed it.
> I think the getter should use SQL query with grouping because it is not efficient to read all the lines out of the database just aggregate them in Python.
I have redone it using SQL.
> I think it will be more extension friendly to get the states list from a common private function.
Yes, I agree, but should I do it properly ? Is it just adding a classmethod in Payment ? Do you have an example of such case in a module ?
> The new fields should be added at least to the list view to allow searching on them.
ah yes. it was an error on my side: I didn't included the files in the commit.
|2018-12-07 14:14:24||semarie||set||messageid: <firstname.lastname@example.org>|
|2018-12-07 14:14:24||semarie||link||issue7890 messages|