Tryton - Issues

 

Message35619

Author ced
Recipients pokoli, risto3, xcodinas
Date 2017-09-10.12:14:01
Content
I do not think any more that reviewboard is a good replacement choice for some reason:

- another application to register and learn
- need customization to support nested patch
- UI more complex than Rietveld
- kind of overlap with the bug-tracker on some aspect.

I would be in favor of mailing-list (with maybe Patchwork).
Indeed using patchbomb (https://www.mercurial-scm.org/wiki/PatchbombExtension) is not so complicated.
I think review by email is very close to the Rietveld workflow. The missing features can be overcome by using mercurial extensions. The expand lines can be solved by just looking at the repository code and/or apply the patch. The side-by-side diff can be fixed by applying the patch and use extdiff.

As mailing-list, I would choose: http://mlmmj.org/ because it works with email only, it is possible to request to resend a specific email (useful to make a review if you did not receive the email).
For flake8 check, we can have the bot subscribed to the ML. It will get the patch from the mail and use subject flag to find the repository. It will run `hg diff -c <rev>|flake8 --diff --show-source` and send a reply with the output.

For now, I see only one point to use Patchwork is to have a permanent link to the patch reviewed from the mailing list and add it to the bug tracker for example. But this could be solved if we have a mailing archive that allow to find email using their Message-Id, so we could just add such link to the bug-tracker.
History
Date User Action Args
2017-09-10 12:14:01cedsetmessageid: <1505038441.96.0.980125239228.issue2178@tryton.org>
2017-09-10 12:14:01cedsetrecipients: + pokoli, risto3, xcodinas
2017-09-10 12:14:01cedlinkissue2178 messages
2017-09-10 12:14:01cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)