Tryton - Issues

 

Message18344

Author duesenfranz
Recipients ajacoutot, bch, ced, daniel, nicoe, sharkcz, yangoon
Date 2014-09-25.12:02:55
Content
>> I think, this one is also a big step to improve the situation. What is your motivation to not apply to the series?

>Because review5601002 is enough to fix the issue.

But the way this works is broken by design: You can't be sure that this is safe, because

* Some of the builtins given to the code [0] may leak globals on some obscure "path" (some attribute of an attribute of an attribute)

* Future python version won't add some attributes to these builtins which might leak globals.

Note that adding attributes wouldn't break backwards compatibility and therefore might even happen within a minor update.

[0] https://github.com/tryton/trytond/blob/feeea16ec199441e558511cf74f9353260f8ae55/trytond/tools/misc.py#L376
History
Date User Action Args
2014-09-25 12:02:56duesenfranzsetmessageid: <1411639376.02.0.0383819775923.issue4155@tryton.org>
2014-09-25 12:02:56duesenfranzsetrecipients: + ced, bch, yangoon, nicoe, sharkcz, daniel, ajacoutot
2014-09-25 12:02:55duesenfranzlinkissue4155 messages
2014-09-25 12:02:55duesenfranzcreate

Showing 10 items. Show all history (warning: this could be VERY long)