Issue 9651

Title
Missing company field on product_cost_history
Priority
bug
Status
resolved
Nosy list
ced, mrichez, reviewbot, roundup-bot, tbruyere
Assigned to
ced
Keywords
review

Created on 2020-09-29.16:47:19 by mrichez, last changed 1 month ago by roundup-bot.

Messages

New changeset d2aea7b05984 by Cédric Krier in branch '5.6':
Ensure get_cost_price_at uses company context or pattern
https://hg.tryton.org/modules/product_cost_history/rev/d2aea7b05984
New changeset 7a15f0944974 by Cédric Krier in branch 'default':
Ensure get_cost_price_at uses company context or pattern
https://hg.tryton.org/tryton-env/rev/7a15f0944974
New changeset 1de1a1a9d22e by Cédric Krier in branch 'default':
Ensure get_cost_price_at uses company context or pattern
https://hg.tryton.org/modules/product_cost_history/rev/1de1a1a9d22e
Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2020-10-11.17:10:14
For me, we do not need to add a company field because:
- we have already _domain_moves_cost
- it makes more complicate to extend cost computation like issue9312

But indeed we are missing the enforcement of the context in get_cost_price_at and the cost history of service is not filtered by company.

Here is review322291002 which solves this in a backportable way.
Author: [hidden] (mrichez)
Date: 2020-09-29.16:47:19
As product cost_price is a multivalue field, we need to add company on product_cost_history to get cost_prices history from the current company.
History
Date User Action Args
2020-10-24 00:06:46roundup-botsetkeyword: - backport
messages: + msg61182
2020-10-19 00:30:32roundup-botsetmessages: + msg61042
2020-10-19 00:30:29roundup-botsetmessages: + msg61041
nosy: + roundup-bot
status: testing -> resolved
2020-10-11 17:33:21reviewbotsetmessages: + msg60793
2020-10-11 17:10:15cedsetreviews: 306501002 -> 306501002,322291002
assignedto: mrichez -> ced
messages: + msg60788
keyword: + backport
nosy: + ced
2020-09-29 17:03:16reviewbotsetnosy: + reviewbot
messages: + msg60467
2020-09-29 17:03:16reviewbotsetreviews: 306501002
keyword: + review
2020-09-29 16:47:19mrichezcreate

Showing 10 items. Show all history (warning: this could be VERY long)