Issue 9632

Title
Error when running tests with werkzeug 0.16
Priority
bug
Status
resolved
Nosy list
ced, pokoli, reviewbot, roundup-bot, yangoon
Assigned to
pokoli
Keywords
review

Created on 2020-09-24.23:12:36 by pokoli, last changed 6 days ago by roundup-bot.

Messages

New changeset dd5be5a6b93b by Sergi Almacellas Abellana in branch 'default':
Do not use original_exception on werkzeug < 1.0
https://hg.tryton.org/tryton-env/rev/dd5be5a6b93b
New changeset 0f5d2a9bd5c7 by Sergi Almacellas Abellana in branch 'default':
Do not use original_exception on werkzeug < 1.0
https://hg.tryton.org/trytond/rev/0f5d2a9bd5c7
Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2020-09-25.09:11:44
For me, werkzeug 1.0.0 is too young to be requested just for a small feature. So I think original_exception should be used optionally.
Author: [hidden] (pokoli) Tryton committer Tryton translator
Date: 2020-09-24.23:12:36
When running the test suite werkzeug 0.16 I get the following exception:

Traceback (most recent call last):
  File "/home/pokoli/projectes/nclone/trytond/trytond/tests/test_wsgi.py", line 37, in test_one_error_handler_called
    (response, status, headers) = client.get('/willfail')
  File "/home/pokoli/.virtualenvs/nclone/lib/python3.8/site-packages/werkzeug/test.py", line 1029, in get
    return self.open(*args, **kw)
  File "/home/pokoli/.virtualenvs/nclone/lib/python3.8/site-packages/werkzeug/test.py", line 993, in open
    response = self.run_wsgi_app(environ.copy(), buffered=buffered)
  File "/home/pokoli/.virtualenvs/nclone/lib/python3.8/site-packages/werkzeug/test.py", line 884, in run_wsgi_app
    rv = run_wsgi_app(self.application, environ, buffered=buffered)
  File "/home/pokoli/.virtualenvs/nclone/lib/python3.8/site-packages/werkzeug/test.py", line 1119, in run_wsgi_app
    app_rv = app(environ, start_response)
  File "/home/pokoli/projectes/nclone/trytond/trytond/wsgi.py", line 188, in __call__
    return self.wsgi_app(environ, start_response)
  File "/home/pokoli/projectes/nclone/trytond/trytond/wsgi.py", line 170, in wsgi_app
    response = self.make_response(request, data)
  File "/home/pokoli/projectes/nclone/trytond/trytond/wsgi.py", line 146, in make_response
    response = InternalServerError(original_exception=data)
TypeError: __init__() got an unexpected keyword argument 'original_exception'


The original_exception argument was added on version 1.0: 

https://werkzeug.palletsprojects.com/en/1.0.x/exceptions/#werkzeug.exceptions.InternalServerError

Since changeset 0131ce3e6648
History
Date User Action Args
2020-10-20 13:05:20roundup-botsetmessages: + msg61081
2020-10-20 13:05:16roundup-botsetmessages: + msg61080
nosy: + roundup-bot
status: testing -> resolved
2020-10-19 23:59:18reviewbotsetmessages: + msg61068
2020-10-19 23:39:04reviewbotsetmessages: + msg61066
2020-09-25 09:31:43yangoonsetnosy: + yangoon
2020-09-25 09:11:44cedsetnosy: + ced
messages: + msg60364
2020-09-24 23:25:58reviewbotsetnosy: + reviewbot
messages: + msg60356
2020-09-24 23:13:35pokolisetreviews: 310551087
keyword: + review
2020-09-24 23:13:22pokolisetstatus: in-progress -> testing
2020-09-24 23:12:36pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)