Issue 9555

Title
The return value of is_zero(amount) is negated if self.currency is not set
Priority
bug
Status
resolved
Nosy list
pokoli, reviewbot, roundup-bot, srgdts
Assigned to
srgdts
Keywords
review

Created on 2020-08-25.18:33:06 by srgdts, last changed 1 week ago by roundup-bot.

Messages

New changeset f155f706d712 by Sergey Datsevich in branch '5.6':
Update taxes only if base changed when currency is empty
https://hg.tryton.org/modules/account_invoice/rev/f155f706d712

New changeset 4d0644ce9934 by Sergey Datsevich in branch '5.4':
Update taxes only if base changed when currency is empty
https://hg.tryton.org/modules/account_invoice/rev/4d0644ce9934

New changeset 81f24fa760d4 by Sergey Datsevich in branch '5.0':
Update taxes only if base changed when currency is empty
https://hg.tryton.org/modules/account_invoice/rev/81f24fa760d4
New changeset ae2d9874a0cc by C├ędric Krier in branch 'default':
Update taxes only if base changed when currency is empty
https://hg.tryton.org/tryton-env/rev/ae2d9874a0cc
New changeset a34e1c79a2fe by Sergey Datsevich in branch 'default':
Update taxes only if base changed when currency is empty
https://hg.tryton.org/modules/account_invoice/rev/a34e1c79a2fe
Author: [hidden] (srgdts)
Date: 2020-08-26.11:28:40
In Invoice::_on_change_lines_taxes(self)
is_zero(amount) returns False for zero amount
Author: [hidden] (pokoli) Tryton committer Tryton translator
Date: 2020-08-26.08:32:33
Could you please describe which is the issue about?

If you are going to work on it please assign it to you and set the proper state
History
Date User Action Args
2020-10-14 00:04:22roundup-botsetmessages: + msg60941
keyword: - backport
2020-10-09 22:02:10roundup-botsetmessages: + msg60751
2020-10-09 22:02:06roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg60750
2020-08-26 12:30:40srgdtssettitle: is_zero(amount) returns False for zero amount -> The return value of is_zero(amount) is negated if self.currency is not set
2020-08-26 11:37:28cedsetkeyword: + backport
2020-08-26 11:28:40srgdtssetstatus: chatting -> testing
assignedto: srgdts
messages: + msg59841
title: Wrong comparison operation -> is_zero(amount) returns False for zero amount
2020-08-26 08:32:33pokolisetnosy: + srgdts, pokoli
messages: + msg59840
2020-08-25 18:58:54reviewbotsetstatus: unread -> chatting
nosy: + reviewbot
messages: + msg59837
2020-08-25 18:33:11srgdtssetreviews: 318111003
keyword: + review
2020-08-25 18:33:06srgdtscreate

Showing 10 items. Show all history (warning: this could be VERY long)