Tryton - Issues

 

Issue9417

Title Work state is not updated after the production is done
Priority bug Status testing
Superseder Nosy List ced, pokoli, reviewbot
Type behavior Components production_work
Assigned To pokoli Keywords review
Reviews 307821002
View: 307821002

Created on 2020-06-15.16:14:12 by pokoli, last changed by reviewbot.

Messages
review307821002 updated at https://codereview.tryton.org/307821002/#ps292041002
msg58715 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-06-15.16:41:53
Yes, what you say is completly valid. My issue is after the production is done. 

Current behaviour is that the works are in 'finished'. But the _state is 'done' when the production is finished. 

The problem is that the work state is never updated when the production is done, so all the works are still in finished state which allows the user to create a new cycle for them (which for me is not correct). Then the work is state is updated to done but there is an active cycle on it. 

So I think the right behaviour is to set all the works to done once the production is done and do not allow to create new cycles.
New review307821002 at https://codereview.tryton.org/307821002/#ps293981002
msg58713 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-06-15.16:24:56
For me, it is not possible to "done" a production order if there are none finished works. And I think it is the proper way to enforce finishing work before the production.
msg58712 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-06-15.16:14:10
Once the production is done it's related works should be updated to done so it is no longer possible to create more cycles for it. 

Currently the works are keep as finished.
History
Date User Action Args
2020-07-04 20:10:18reviewbotsetmessages: + msg58975
2020-06-15 16:41:54pokolisetmessages: + msg58715
2020-06-15 16:33:14reviewbotsetnosy: + reviewbot
messages: + msg58714
2020-06-15 16:33:11reviewbotsetreviews: 307821002
keyword: + review
2020-06-15 16:24:57cedsetnosy: + ced
messages: + msg58713
2020-06-15 16:15:37pokolisetstatus: in-progress -> testing
2020-06-15 16:14:12pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)