Tryton - Issues

 

Issue9398

Title Use timesheet hours to compute revenue
Priority feature Status testing
Superseder Nosy List albertca, ced, pokoli, reviewbot
Type feature request Components project_revenue
Assigned To pokoli Keywords review
Reviews 291921002
View: 291921002

Created on 2020-06-08.19:39:03 by pokoli, last changed by reviewbot.

Messages
review291921002 updated at https://codereview.tryton.org/291921002/#ps294201005
review291921002 updated at https://codereview.tryton.org/291921002/#ps306071002
review291921002 updated at https://codereview.tryton.org/291921002/#ps327491002
review291921002 updated at https://codereview.tryton.org/291921002/#ps323471002
review291921002 updated at https://codereview.tryton.org/291921002/#ps295761002
review291921002 updated at https://codereview.tryton.org/291921002/#ps297911002
msg58625 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-06-09.09:29:50
Understood. So for me it is not clear that the revenue is about planned revenue but not real invoice. 

I've added review291921002 which introduces the help texts for this module so it is clarified.
msg58624 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-06-09.09:16:06
On 2020-06-09 08:21, Sergi Almacellas Abellana wrote:
> In this module nothing define how the project will be invoiced.
> 
> For me there are three possibilities here:
> 
> * Fixed amount project. This is correctly managed as the list price is used

But if the planned hours are not set but timesheet has already been
filled. This results of wrong information.

> * Hourly projects invoiced on estimation: This is correctly computed.
> * Hourly projects invoiced from timesheets: If you invoice from timesheets you do not know the effort, so you leave it blank. Currently the revenue is always zero.

Except that it changes at every timesheet line encoded.

The revenue represent the theoretical amount that should generate the
project. This is the target to compare with the invoiced amount.
When a project has no estimation and it is based only on timesheet
invoiced, there is indeed no target as we do not know when it will end
and how much time will be spent. This uncertainty must be explicit
instead of hiding behind a false computation.
msg58623 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-06-09.08:21:16
> For me, it is not correct. If there is no estimation, it means that the planned revenue is not known.

If it is not known the project has not been started and there is no timesheet duration. So both hours will be empty and revenue will be zero. Once the estimation is set the planned revenue will be updated (no mather if the project started or not). So the system will always produce a value with the values it has.

> More over, in this module nothing define that it is the timesheet hours that will be invoiced.

In this module nothing define how the project will be invoiced.

For me there are three possibilities here:

* Fixed amount project. This is correctly managed as the list price is used
* Hourly projects invoiced on estimation: This is correctly computed.
* Hourly projects invoiced from timesheets: If you invoice from timesheets you do not know the effort, so you leave it blank. Currently the revenue is always zero.
msg58622 (view) Author: [hidden] (albertca) (Tryton committer) Date: 2020-06-09.00:44:56
I agree with C├ędric.
msg58616 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-06-08.22:05:26
For me, it is not correct. If there is no estimation, it means that the planned revenue is not known.
More over, in this module nothing define that it is the timesheet hours that will be invoiced.
New review301771002 at https://codereview.tryton.org/301771002/#ps327411002
msg58614 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-06-08.19:39:03
When a task is invoiced on hours and it does not have any estimated effort it's revenue is set to zero.

But if it has some timesheet hours we can asume that this hours will be the used billed to the customer, so it's the revenue.
History
Date User Action Args
2020-07-15 10:45:41reviewbotsetmessages: + msg59340
2020-07-09 22:16:40reviewbotsetmessages: + msg59247
2020-06-24 10:54:41reviewbotsetmessages: + msg58847
2020-06-09 14:45:25reviewbotsetmessages: + msg58634
2020-06-09 13:07:44reviewbotsetmessages: + msg58630
2020-06-09 09:36:35reviewbotsetmessages: + msg58626
2020-06-09 09:29:51pokolisetstatus: in-progress -> testing
reviews: 301771002 -> 291921002
messages: + msg58625
2020-06-09 09:16:06cedsetmessages: + msg58624
2020-06-09 08:21:17pokolisetmessages: + msg58623
2020-06-09 00:44:57albertcasetnosy: + albertca
messages: + msg58622
2020-06-08 22:05:26cedsetnosy: + ced
messages: + msg58616
2020-06-08 20:06:47reviewbotsetnosy: + reviewbot
messages: + msg58615
2020-06-08 20:06:47reviewbotsetreviews: 301771002
keyword: + review
2020-06-08 19:39:03pokolicreate