Tryton - Issues

 

Issue9355

Title Prevent doing move in the future
Priority feature Status testing
Superseder Nosy List albertcuni, ced, mrichez, pokoli, reviewbot
Type feature request Components stock
Assigned To albertcuni Keywords review
Reviews 327351002
View: 327351002

Created on 2020-05-20.13:07:22 by ced, last changed by reviewbot.

Messages
review327351002 updated at https://codereview.tryton.org/327351002/#ps290801002
review327351002 updated at https://codereview.tryton.org/327351002/#ps327841002
review327351002 updated at https://codereview.tryton.org/327351002/#ps312071002
review327351002 updated at https://codereview.tryton.org/327351002/#ps311971002
review327351002 updated at https://codereview.tryton.org/327351002/#ps301981008
review327351002 updated at https://codereview.tryton.org/327351002/#ps325841003
review327351002 updated at https://codereview.tryton.org/327351002/#ps315721002
review327351002 updated at https://codereview.tryton.org/327351002/#ps311861002
review327351002 updated at https://codereview.tryton.org/327351002/#ps295801002
review327351002 updated at https://codereview.tryton.org/327351002/#ps323461002
New review327351002 at https://codereview.tryton.org/327351002/#ps309801004
msg58176 (view) Author: [hidden] (mrichez) Date: 2020-05-20.14:14:46
indeed :-)
msg58175 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-05-20.13:40:03
On 2020-05-20 13:19, Maxime Richez wrote:
> Does it concerns only effective_date on move?

Yes because planned date by definition is in the future most of the time.
msg58174 (view) Author: [hidden] (mrichez) Date: 2020-05-20.13:19:48
Does it concerns only effective_date on move?
msg58173 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-05-20.13:07:22
From: https://discuss.tryton.org/t/user-mistakes-when-introducing-dates-in-different-forms/2738
We have already the stock period to prevent to do move in the past. But indeed there is no reason to make stock move in the future. So we should add a validation (using the company timezone). This will prevent user mistakes.
History
Date User Action Args
2020-08-14 12:42:25reviewbotsetmessages: + msg59728
2020-08-14 09:55:20reviewbotsetmessages: + msg59725
2020-08-13 13:17:22reviewbotsetmessages: + msg59720
2020-07-29 19:37:03pokolisetstatus: in-progress -> testing
2020-07-29 09:23:05reviewbotsetmessages: + msg59526
2020-07-28 10:50:46reviewbotsetmessages: + msg59517
2020-07-28 09:51:14reviewbotsetmessages: + msg59514
2020-07-21 10:46:03reviewbotsetmessages: + msg59394
2020-07-14 10:42:24reviewbotsetmessages: + msg59317
2020-06-23 12:25:04reviewbotsetmessages: + msg58833

Showing 10 items. Show all history (warning: this could be VERY long)