Tryton - Issues

Missatge de Cédric Krier <bugs@tryton.org> del dia dt., 12 de maig 2020 a
les 17:09:

>
> Cédric Krier <cedric.krier@b2ck.com> added the comment:
>
> On 2020-05-12 16:59, Albert Cervera i Areny wrote:
> > The proposal is an improvement because at least prevents corrupting data
> but at the same time what is the purpose of considering both configuration
> file and ir.configuration settings?
>
> By design the field definition can not depend on a setting in the
> database because the field define the database schema.
> And for performance, we cannot read in the database each time we need
> this value. It would be too expensive and slow. And using a Function
> field would add a lot of code on many models for no benefit (as any way
> the UI user can not modify it).
>

Understood.

>
> ______________________________________
> Tryton issue tracker <bugs@tryton.org>
> <https://bugs.tryton.org/issue9324>
> ______________________________________
>

On 2020-05-12 16:59, Albert Cervera i Areny wrote:
> The proposal is an improvement because at least prevents corrupting data but at the same time what is the purpose of considering both configuration file and ir.configuration settings?

By design the field definition can not depend on a setting in the
database because the field define the database schema.
And for performance, we cannot read in the database each time we need
this value. It would be too expensive and slow. And using a Function
field would add a lot of code on many models for no benefit (as any way
the UI user can not modify it).

The proposal is an improvement because at least prevents corrupting data but at the same time what is the purpose of considering both configuration file and ir.configuration settings?

We already know that the right setting is the one in ir.configuration so why should we care about what's in the configuration file? Specially if there's no setting in the configuration file. We could emit a warning in the log if we really care about that.

But for me this and the language, is a setting that the user should supply the very first time it creates the database, and later we just use what's in ir.configuration.

Following https://discuss.tryton.org/t/store-unit-price-digits-config-setting-in-the-database/2218

It may be a damaging issue to change the price_digits so we need to ensure to not start working with the wrong value. For that we store the initial value in ir.configuration and check on pool initialization.