Issue 9266

Title
Tryton keeps a reference to unused Combobox in editable trees
Priority
bug
Status
resolved
Nosy list
ced, nicoe, reviewbot, roundup-bot
Assigned to
ced
Keywords
review

Created on 2020-04-27.11:48:26 by nicoe, last changed 3 days ago by roundup-bot.

Messages

New changeset c53a174a9321 by Cédric Krier in branch 'default':
Use editable path to update editable on display
https://hg.tryton.org/tryton-env/rev/c53a174a9321
New changeset 07b4d22509fc by Cédric Krier in branch 'default':
Use editable path to update editable on display
https://hg.tryton.org/tryton/rev/07b4d22509fc
Author: [hidden] (ced) Tryton committer Tryton translator
Date: 2020-10-16.11:41:17
I'm not sure if it is an issue of GTK. I think GTK expect that Combobox editing is stopped only by keyboard. But we added other ways in tryton: new button, tab etc. So I think we must manage it ourselves with review314471002.
Author: [hidden] (nicoe) Tryton committer
Date: 2020-04-27.11:48:25
As explained in https://codereview.tryton.org/289791002/diff/313311002/tryton/tryton/gui/window/view_form/view/list_gtk/editabletree.py#newcode194 GTK will keep a reference to the editable ComboBox because the 'remove-widget' is not sent for CellRendererCombo on the focus-out.

I asked (without much success) for an explanation on GNOME's discourse: https://discourse.gnome.org/t/the-focus-out-event-on-the-cellrenderercombo-do-not-emit-the-remove-widget-signal/3173

The workaround I proposed is to launch ourselves the signal on the focus-out.
History
Date User Action Args
2020-10-21 23:21:55roundup-botsetmessages: + msg61131
2020-10-21 23:21:51roundup-botsetmessages: + msg61129
nosy: + roundup-bot
status: testing -> resolved
2020-10-16 12:06:08reviewbotsetnosy: + reviewbot
messages: + msg60987
2020-10-16 11:41:17cedsetstatus: unread -> testing
keyword: + review
nosy: + ced
messages: + msg60985
reviews: 314471002
assignedto: nicoe -> ced
2020-10-16 09:46:06cedlinkissue9618 superseder
2020-04-27 11:48:26nicoecreate

Showing 10 items. Show all history (warning: this could be VERY long)