Tryton - Issues

 

Issue9221

Title EC Operation List shows canceled purchase invoices
Priority bug Status in-progress
Superseder Nosy List ced, josesalvador, pokoli, reviewbot
Type behavior Components account_es, account_eu
Assigned To josesalvador Keywords backport, review
Reviews 295401002
View: 295401002

Created on 2020-04-13.09:42:25 by josesalvador, last changed by josesalvador.

Messages
New review295401002 at https://codereview.tryton.org/295401002/#ps293481003
msg57195 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-04-16.10:26:44
Here is review295401002 which adds the required filters also improve the cancell invoice scenario to test this case.
msg57170 (view) Author: [hidden] (josesalvador) Date: 2020-04-15.12:47:00
> Yes, but as far as customer invoices can also be cancelled (when refunded they are marked as cancelled) we should also take them in account. 

> I will not do any distinction here and fix both cases. This means adding the cancel state filter and also exclude "canceled moves" as we did on issue9097

Understood, so in this case, just for information, are you still ensuring it will be needed to update account_eu too?
msg57169 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-04-15.11:42:56
>> I'm talking all time about canceled (and not refund) **purchase** (from supplier) invoices **not canceled customer invoices**.

Yes, but as far as customer invoices can also be cancelled (when refunded they are marked as cancelled) we should also take them in account. 

I will not do any distintion here and fix both cases. This means adding the cancel state filter and also exclude "canceled moves" as we did on issue9097
msg57168 (view) Author: [hidden] (josesalvador) Date: 2020-04-15.11:17:23
@pokoli @ced remember I'm talking all time about canceled (and not refund) **purchase** (from supplier) invoices **not canceled customer invoices**.
msg57167 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-04-15.11:00:04
On 2020-04-15 10:10, Sergi Almacellas Abellana wrote:
> > I do not see why account_eu should be modified?
> As far as we allow to cancel custom invoices I think it's safer to also exclude the cancelled invoices.

For me, it is a big problem because (except Spanish) I do not know a
country that allow to "update" such report after sending it.
Canceling a customer invoice should always be done with a credit note in
Europe.
msg57165 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-04-15.10:10:08
> I do not see why account_eu should be modified?
As far as we allow to cancel custom invoices I think it's safer to also exclude the cancelled invoices.
msg57164 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-04-15.10:00:34
I do not see why account_eu should be modified?
msg57163 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-04-15.09:46:43
Ok, so we should add a cancel filter on Spanish and European EC Operation list. 

But if we make this filter we should also include the cancel invoices like we did in issue9097
msg57091 (view) Author: [hidden] (josesalvador) Date: 2020-04-13.13:09:39
Not exactly...

In issue9097 we're talking about a customer refund so in this case all the invoices/moves must be taken into account.

In this case I'm talking about a cancel (not refund) of purchase invoice which was accounted as mistake.

In other words I think that:

- A cancel purchase invoice must not be taken into account
- A refund purchase invoice must be taken into account
msg57076 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-04-13.11:42:21
@josesalvador is this similar to issue9097 but for Spanish EC Operation List?
msg57075 (view) Author: [hidden] (josesalvador) Date: 2020-04-13.10:18:11
IIUC when you cancel a purchase invoice (eg to correct a purchase invoice accounted as mistake) Tryton cancel it generating a counterpart move.

So IMHO that operation must not be showed in EC Operation List or at least it should be showed as zero amount (although I don't like the last one alternative...)
msg57074 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-04-13.10:04:05
As long as they have accounting move, for me it is expected.
msg57073 (view) Author: [hidden] (josesalvador) Date: 2020-04-13.09:42:25
EC Operation List shows canceled purchase invoices
History
Date User Action Args
2020-05-22 08:18:46josesalvadorsetstatus: testing -> in-progress
2020-05-21 11:10:28pokolisetassignedto: pokoli -> josesalvador
2020-04-16 10:42:06reviewbotsetnosy: + reviewbot
messages: + msg57196
2020-04-16 10:42:05reviewbotsetreviews: 295401002
keyword: + review
2020-04-16 10:26:45pokolisetstatus: chatting -> testing
assignedto: pokoli
messages: + msg57195
keyword: + backport
2020-04-15 12:47:00josesalvadorsetmessages: + msg57170
2020-04-15 11:42:57pokolisetmessages: + msg57169
2020-04-15 11:17:24josesalvadorsetmessages: + msg57168
2020-04-15 11:00:05cedsetmessages: + msg57167
2020-04-15 10:10:08pokolisetmessages: + msg57165

Showing 10 items. Show all history (warning: this could be VERY long)