Tryton - Issues

 

Issue9145

Title selecting payment in statement origin doesn't respect account
Priority feature Status chatting
Superseder Ensure clearing account is used on statement, Merge invoice, payment and payment group in statement line
View: 9164, 6854
Nosy List ced, pokoli, risto3
Type feature request Components account_payment
Assigned To Keywords
Reviews

Created on 2020-03-11.08:42:44 by risto3, last changed by ced.

Files
File name Uploaded Type Edit Remove
statement.diff risto3, 2020-03-28.07:37:21 text/plain
Messages
msg56724 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-03-28.13:04:59
Indeed the payment may pay a line from a different account. If no clearing is used, it may be helpful to set by default the account from the line of the payment. So this is linked to account_payment only not account_payment_clearing (even if issue9164 will be needed to have proper behavior).
But I think before implementing this behavior, issue6854 should be fixed (see msg51856) because the complexity increases when dealing with many fields to fill the account.
msg56723 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-03-28.11:58:14
Normally the payment account should be the same the party receivable. 

So it should work out of the box without any additional patch.
msg56722 (view) Author: [hidden] (risto3) Date: 2020-03-28.11:29:55
except the patch in issue9164 unfortunately does nothing for this issue...
payment.line.account must be used if no clearing account is set.
msg56721 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-03-28.10:52:55
Duplicate issue9164
msg56719 (view) Author: [hidden] (risto3) Date: 2020-03-28.07:37:21
> Indeed if there is no clearing set and no account filled, on_change_payment 
> could use the account of the line if there is one.

I must admit not to well understand the existing code.
I would have thought that if clearing was set, it be mandatory.
But the implementation is only if there is no account already set, which seems odd.

Therefore, in the attached I always set the account used in the payment prior to the questionable clearing account code, as we frequently see improper accounts set by default entering the statement origin line form.
msg56206 (view) Author: [hidden] (risto3) Date: 2020-03-11.12:59:02
finally, I am also surprised that when validating the statement after correcting the account, the payment line is not even reconciled with the statement move line! If it was an invoice selected, and not a payment, the line *is* reconciled.
msg56205 (view) Author: [hidden] (risto3) Date: 2020-03-11.12:48:51
I notice that sometimes when selecting the supplier, the account automatically fills in, and in this case it is the wrong one.
This should also be bugfixed, please.
msg56196 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-03-11.10:04:42
Indeed if there is no clearing set and no account filled, on_change_payment could use the account of the line if there is one.
msg56193 (view) Author: [hidden] (risto3) Date: 2020-03-11.08:42:43
still difficulties with grouping payments and statements.

Scenario:
- supplier issues bill of exchange for 1 or more invoices in period
- group the payment lines (from French account 401100)
- correct the primary move dates and set grouped amount line to account 403000; then post
- pay the line and approve
- in the statement origin, select the supplier and appropriate payment line

instead of setting account to 403000 it is set to 401100

It should be set to the account in the payment line
History
Date User Action Args
2020-03-28 13:05:00cedsetsuperseder: + Merge invoice, payment and payment group in statement line
component: + account_payment, - account_payment_clearing
messages: + msg56724
keyword: - patch
2020-03-28 11:58:24pokolisetpriority: bug -> feature
2020-03-28 11:58:15pokolisetmessages: + msg56723
2020-03-28 11:30:38risto3setpriority: feature -> bug
2020-03-28 11:29:55risto3setstatus: closed -> chatting
nosy: + pokoli
messages: + msg56722
2020-03-28 10:52:55cedsetstatus: chatting -> closed
superseder: + Ensure clearing account is used on statement
messages: + msg56721
2020-03-28 07:37:22risto3setfiles: + statement.diff
messages: + msg56719
keyword: + patch
2020-03-11 12:59:02risto3setmessages: + msg56206
2020-03-11 12:48:52risto3setmessages: + msg56205
2020-03-11 10:04:50cedsetcomponent: + account_payment_clearing

Showing 10 items. Show all history (warning: this could be VERY long)