Tryton - Issues

 

Issue9090

Title Add export CSV route
Priority feature Status resolved
Superseder Nosy List ced, josesalvador, reviewbot, roundup-bot
Type feature request Components sao, tryton, trytond
Assigned To ced Keywords review
Reviews 261011002
View: 261011002

Created on 2020-02-25.19:15:54 by ced, last changed by roundup-bot.

Files
File name Uploaded Type Edit Remove
2020-02-25-191757_1920x1080_scrot.png ced, 2020-02-25.19:19:09 image/png
Screenshot_2020-02-25 Parties - Tryton.png ced, 2020-02-25.19:18:59 image/png
alternative_URL_UI.png josesalvador, 2020-02-26.16:50:13 image/png
Messages
New changeset 854174534199 by Cédric Krier in branch 'default':
Add export CSV data route
https://hg.tryton.org/tryton-env/rev/854174534199
New changeset e081ba83d876 by Cédric Krier in branch 'default':
Add export CSV data route
https://hg.tryton.org/trytond/rev/e081ba83d876
New changeset 83393c481464 by Cédric Krier in branch 'default':
Add export CSV data route
https://hg.tryton.org/tryton/rev/83393c481464
New changeset 0dc1b7259e68 by Cédric Krier in branch 'default':
Add export CSV data route
https://hg.tryton.org/sao/rev/0dc1b7259e68
review261011002 updated at https://codereview.tryton.org/261011002/#ps278951002
review261011002 updated at https://codereview.tryton.org/261011002/#ps299251002
review261011002 updated at https://codereview.tryton.org/261011002/#ps303251002
review261011002 updated at https://codereview.tryton.org/261011002/#ps319081002
review261011002 updated at https://codereview.tryton.org/261011002/#ps297121036
msg55627 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-02-27.19:43:41
I just found that IMPORTDATA from Google spreadsheet does not support  authentication on the URL. I'm wondering if we should support alternative authentication via arguments? Of course it should not contain user/password but some sharing key.
msg55608 (view) Author: [hidden] (josesalvador) Date: 2020-02-26.17:34:05
> I do not have the resource to work on your prototype.

I perfectly understand that.

> So if you want it to be considered please provide an alternative implementation.

I would do if I would have enough knowledge to do it.

I am still learning and doing an effort to contribute all as I can to the Tryton community through discuss, ideas/opinion (this case) or little fixes (even with code https://hg.tryton.org/modules/account_payment_sepa/rev/00a53d5e615e :-D ).

I just try to help so much as I can nowadays.

Don't hesitate to cut me when you consider that the things I say have no sense or are delaying your work.

Thank you very much for your time Ced.

Greets.
msg55607 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-02-26.17:14:59
I do not have the resource to work on your prototype. So if you want it to be considered please provide an alternative implementation.
msg55606 (view) Author: [hidden] (josesalvador) Date: 2020-02-26.16:50:13
I guess I am understanding the problem better thanks to your explanations.

Anyway it still sounds strange to me to place a button to get a data (the URL) with apparently the same importance that save and delete export actions.

I'm gonna to give you another idea to show the URL without a button.

It would consist in a run time URL building while user is configuring the export. (if this solution is good performant and does not require round trips to the server, of course).

It will be showed in a read only field with the ability to be copied to clipboard (if Tryton is able to do that) like github does.

I attach an image prototype with this proposal.

Excuse me in advance for my poor abilities managing GIMP. :-(
msg55599 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-02-26.15:18:03
On 2020-02-26 11:44, José Salvador wrote:
> > Why would you want to make it an option?
> > y this behavior instead of reusing the same design for resource URL?
> 
> I think it is more user-friendly because the user has a unique export with the capacity to become it 'URL exportable'.
> 
> For me, showing another button can lead to confusion. It's like the user would have two exports instead of one when really there is only one export process (that can be saved) and this one is the CSV export that the user can become it as a 'URL exportable' too.

I placed with the Save and Delete button because it is a management
action (not the principal action). That's why clicking on it does not
close the dialog (but open on a new tab). But the main goal is to allow
to copy it with the right-click.

For me, your proposal will be confusing because what will happen if I
select the checkbox for exportable URL and than I click on OK? I think
some user will think it should give the URL and other would think it
should close the dialog (but then what is the point of the cancel
button).
msg55598 (view) Author: [hidden] (josesalvador) Date: 2020-02-26.11:44:22
> Why would you want to make it an option?
> y this behavior instead of reusing the same design for resource URL?

I think it is more user-friendly because the user has a unique export with the capacity to become it 'URL exportable'.

For me, showing another button can lead to confusion. It's like the user would have two exports instead of one when really there is only one export process (that can be saved) and this one is the CSV export that the user can become it as a 'URL exportable' too.
msg55597 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-02-26.11:35:04
On 2020-02-26 11:02, José Salvador wrote:
> > You want an option button to show the URL button. I do not see the point.
> > Also this has no relation with the CSV parameters.
> 
> Nope. I propose a check box to activate or not the 'URL export' as an option of the export process not as an option of CSV parameters.

Why would you want to make it an option?

> Once the user choose (activating the checkbox) that export should be 'URL exportable' a read only field will appear to show the URL.

Why this behavior instead of reusing the same design for resource URL?
msg55596 (view) Author: [hidden] (josesalvador) Date: 2020-02-26.11:02:49
> You want an option button to show the URL button. I do not see the point.
> Also this has no relation with the CSV parameters.

Nope. I propose a check box to activate or not the 'URL export' as an option of the export process not as an option of CSV parameters.

Once the user choose (activating the checkbox) that export should be 'URL exportable' a read only field will appear to show the URL.

This way there is no need to show another button for the URL export. The 'URL exportable' feature is just an option for the general CSV export process.

PS -> I didn't see you posted the screenshots in the discuss thread so I tried in first attempt to help here instead of discuss. If you consider that this comments should be published in discuss thread (I guess yes) let me know to follow the discussion there.

Thanks @ced.
msg55595 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-02-26.10:42:05
On 2020-02-26 10:25, José Salvador wrote:
> What do you think about to show in the UI the 'URL export' as option instead of a button?
> 
> I mean, for example, before 'CSV Parameters', something like that:
> 
> X URL export    if_activated_this_will_represent_a_read_only_field_with_the_URL
> 
> I hope you understand what I'm trying to mean...

You want an option button to show the URL button. I do not see the point.
Also this has no relation with the CSV parameters.
msg55594 (view) Author: [hidden] (josesalvador) Date: 2020-02-26.10:25:14
What do you think about to show in the UI the 'URL export' as option instead of a button?

I mean, for example, before 'CSV Parameters', something like that:

X URL export    if_activated_this_will_represent_a_read_only_field_with_the_URL

I hope you understand what I'm trying to mean...
review261011002 updated at https://codereview.tryton.org/261011002/#ps266871002
msg55584 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-02-25.19:20:33
Here is review261011002. I added two screenshots to show how it looks like.
So mainly I added a button under the save which allows to copy (or open) the URL.
I also added an option to allow to export all the listed records instead of just the selected (as usual).
msg55583 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-02-25.19:15:54
Following https://discuss.tryton.org/t/export-csv-data-from-url/2363
History
Date User Action Args
2020-04-12 23:11:03roundup-botsetmessages: + msg57058
2020-04-12 23:10:56roundup-botsetmessages: + msg57057
2020-04-12 23:10:53roundup-botsetmessages: + msg57056
2020-04-12 23:10:50roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg57055
2020-04-03 18:21:50reviewbotsetmessages: + msg56879
2020-04-02 18:24:53reviewbotsetmessages: + msg56852
2020-04-02 16:50:03reviewbotsetmessages: + msg56851
2020-03-28 00:27:11reviewbotsetmessages: + msg56707
2020-03-02 00:32:37reviewbotsetmessages: + msg55975
2020-02-27 19:43:41cedsetmessages: + msg55627
2020-02-26 17:34:05josesalvadorsetmessages: + msg55608
2020-02-26 17:14:59cedsetmessages: + msg55607
2020-02-26 16:50:13josesalvadorsetfiles: + alternative_URL_UI.png
messages: + msg55606
2020-02-26 15:18:04cedsetmessages: + msg55599
2020-02-26 11:44:23josesalvadorsetmessages: + msg55598
2020-02-26 11:35:05cedsetmessages: + msg55597
2020-02-26 11:02:50josesalvadorsetmessages: + msg55596
2020-02-26 10:42:05cedsetmessages: + msg55595
2020-02-26 10:25:15josesalvadorsetnosy: + josesalvador
messages: + msg55594
2020-02-25 19:40:32reviewbotsetnosy: + reviewbot
messages: + msg55585
2020-02-25 19:20:33cedsetmessages: + msg55584
2020-02-25 19:19:17cedsetstatus: in-progress -> testing
reviews: 261011002
keyword: + review
2020-02-25 19:19:09cedsetfiles: + 2020-02-25-191757_1920x1080_scrot.png
2020-02-25 19:18:59cedsetfiles: + Screenshot_2020-02-25 Parties - Tryton.png
2020-02-25 19:15:54cedcreate