Tryton - Issues

 

Issue9075

Title Drop shipment customer moves are not created properly in case of same product on sale order twice
Priority bug Status resolved
Superseder Nosy List ced, prakashpp, reviewbot, roundup-bot
Type behavior Components sale_supply_drop_shipment
Assigned To ced Keywords review
Reviews 315271002
View: 315271002

Created on 2020-02-20.10:03:09 by prakashpp, last changed by roundup-bot.

Messages
New changeset 1c6b22d4f22a by Cédric Krier in branch '5.4':
Do not rely on unique link between request and purchase or sale lines
https://hg.tryton.org/modules/sale_supply_drop_shipment/rev/1c6b22d4f22a

New changeset acef00349c65 by Cédric Krier in branch '5.2':
Do not rely on unique link between request and purchase or sale lines
https://hg.tryton.org/modules/sale_supply_drop_shipment/rev/acef00349c65

New changeset 2f9e92d60164 by Cédric Krier in branch '5.0':
Do not rely on unique link between request and purchase or sale lines
https://hg.tryton.org/modules/sale_supply_drop_shipment/rev/2f9e92d60164
New changeset dd7eb325da84 by Cédric Krier in branch 'default':
Do not rely on unique link between request and purchase or sale lines
https://hg.tryton.org/tryton-env/rev/dd7eb325da84
New changeset 2de777c46af5 by Cédric Krier in branch 'default':
Do not rely on unique link between request and purchase or sale lines
https://hg.tryton.org/modules/sale_supply_drop_shipment/rev/2de777c46af5
review315271002 updated at https://codereview.tryton.org/315271002/#ps319231002
review315271002 updated at https://codereview.tryton.org/315271002/#ps313361002
msg57281 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-04-18.22:55:11
Here is review315271002 which should solve it.
msg55483 (view) Author: [hidden] (prakashpp) Date: 2020-02-20.10:03:08
There is a problem in dropshipment creation in specific case below:

1) Create sale order with two lines and keep same product in both the lines
2) when the dropshipment is created, it consists customer move for first sale line, skips the second line completely. This has started happening since the purchase request merges to a single purchase line.

In this particular case logic here[1] should expect that there could be two purchase requests per purchase line since the merging of purchase line from purchase requests.

[1] https://github.com/tryton/sale_supply_drop_shipment/blob/5.0/stock.py#L514
History
Date User Action Args
2020-04-29 16:44:13roundup-botsetmessages: + msg57715
keyword: - backport
2020-04-23 21:40:12roundup-botsetmessages: + msg57377
2020-04-23 21:40:05roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg57376
2020-04-23 21:38:57cedsetkeyword: + backport
2020-04-19 10:14:00cedsettitle: Dropshipment customer moves are not created properly in case of same product on sale order twice -> Drop shipment customer moves are not created properly in case of same product on sale order twice
2020-04-19 10:11:30reviewbotsetmessages: + msg57286
2020-04-18 23:08:06reviewbotsetnosy: + reviewbot
messages: + msg57283
2020-04-18 22:55:11cedsetstatus: unread -> testing
messages: + msg57281
keyword: + review
nosy: + ced
component: + sale_supply_drop_shipment
reviews: 315271002
assignedto: ced
2020-02-20 10:03:09prakashppcreate

Showing 10 items. Show all history (warning: this could be VERY long)