Tryton - Issues

 

Issue9027

Title Empty space on screen context with many2many fields
Priority bug Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type behavior Components sao
Assigned To ced Keywords review
Reviews 276861002
View: 276861002

Created on 2020-01-30.15:28:06 by pokoli, last changed by roundup-bot.

Files
File name Uploaded Type Edit Remove
Screenshot_2020-01-30 Salable Products - Tryton.png pokoli, 2020-01-30.15:28:05 image/png
Messages
New changeset 3f49cd493483 by Cédric Krier in branch '5.4':
Do not remove 25vw in max-width
https://hg.tryton.org/sao/rev/3f49cd493483
New changeset 42ee7c9212fc by Cédric Krier in branch 'default':
Do not remove 25vw in max-width
https://hg.tryton.org/tryton-env/rev/42ee7c9212fc
New changeset aa837fed0c3a by Cédric Krier in branch 'default':
Do not remove 25vw in max-width
https://hg.tryton.org/sao/rev/aa837fed0c3a
review276861002 updated at https://codereview.tryton.org/276861002/#ps256551002
msg55307 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-02-11.00:45:52
This comes from rev 2de13120296f.
Indeed the subtraction of 25vw is wrong because this accumulate if there are multiple xexpanded cell in the same row.
So I think we could just ignore the offcanvas size at worse this will create an horizontal scrollbar when the menu it shown.
Here is review276861002
msg55149 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-01-30.15:28:05
While testing issue8981 i've just found that there is a lot of empty space in the right side of the context view (see attached screenshot). 

This is because the td of the form view have the "max-width: 25vw;" inline css style. By removing this attrbute everything works as expected.
History
Date User Action Args
2020-02-25 22:03:36roundup-botsetmessages: + msg55589
keyword: - backport
2020-02-19 23:01:54roundup-botsetmessages: + msg55482
2020-02-19 23:01:45roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg55481
2020-02-19 23:00:51cedsetkeyword: + backport
2020-02-11 00:50:17reviewbotsetnosy: + reviewbot
messages: + msg55308
2020-02-11 00:47:09cedlinkissue9051 superseder
2020-02-11 00:45:56cedsetstatus: unread -> testing
keyword: + review
nosy: + ced
messages: + msg55307
reviews: 276861002
assignedto: ced
2020-01-30 15:28:06pokolicreate