Created on 2019-11-08.14:01:29 by xcodinas, last changed 2 months ago by roundup-bot.
New changeset e9be3ad5c9c9 by Cédric Krier in branch 'default': Add scheduled task to update rates https://hg.tryton.org/tryton-env/rev/e9be3ad5c9c9
New changeset 2fb24d104afb by Cédric Krier in branch 'default': Add scheduled task to update rates https://hg.tryton.org/modules/currency/rev/2fb24d104afb
I have started a new review347191002 which include the latest remarks about the design. The design allow to have multiple frequency per currencies and even from different sources. The only advise is to always use the same base currency which I documented. In theory different base currency could work if each currency convertion possible is updated each time.
I also filled https://github.com/MicroPyramid/forex-python/pull/83 in order to ensure to get the proper rate for today.
I've added the option to select the source and the frequency allowing both options to be customized. Currently forex-python only provides a single value for a day, but if somebody implements other methods that provide multiple values we may add several options for the sources. For example: - Service Name (Daily Average) - Service Name (Daily Opening) This allows us to keep our desing simple while supporting multiple options.
For me, it is missing the pieces described in https://discuss.tryton.org/t/automatically-update-currency-rates/1922/5 This requires a kind of scheduler a little bit like in the sale_subscription module.
I've uploaded review321901002 which is updated to tip and has a more modular design to allow to customize the source of the rates.
|2021-02-21 19:31:40||roundup-bot||set||messages: + msg64756|
nosy: + roundup-bot
status: testing -> resolved
|2021-02-05 21:49:17||reviewbot||set||messages: + msg64347|
|2020-12-30 23:55:29||reviewbot||set||messages: + msg63721|
|2020-12-30 15:52:28||reviewbot||set||messages: + msg63706|
|2020-12-30 15:42:12||ced||set||assignedto: pokoli -> ced|
messages: + msg63705
reviews: 286271002, 321901002 -> 286271002, 321901002,347191002
|2020-08-10 18:15:26||reviewbot||set||messages: + msg59671|
|2020-08-01 11:16:42||reviewbot||set||messages: + msg59579|
|2020-08-01 11:15:38||pokoli||set||messages: + msg59578|
messages: + msg59576
|2020-07-31 19:53:33||reviewbot||set||messages: + msg59575|
|2020-07-31 19:53:32||reviewbot||set||reviews: 286271002 -> 286271002, 321901002|
|2020-07-31 19:27:14||pokoli||set||status: chatting -> testing|
assignedto: xcodinas -> pokoli
type: behavior -> feature request
messages: + msg59574
nosy: + pokoli
|2019-11-08 15:27:25||reviewbot||set||messages: + msg53096|
|2019-11-08 14:29:33||reviewbot||set||status: unread -> chatting|
nosy: + reviewbot
messages: + msg53095
|2019-11-08 14:11:34||xcodinas||set||reviews: 286271002|
keyword: + review