Tryton - Issues



Title Timestamp should always read
Priority bug Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type behavior Components proteus
Assigned To ced Keywords review
Reviews 268331002
View: 268331002

Created on 2019-11-04.23:07:32 by ced, last changed by roundup-bot.

New changeset c794cc47d6c2 by Cédric Krier in branch '5.4':
Always read _timestamp

New changeset f6ef0e2e1b4e by Cédric Krier in branch '5.2':
Always read _timestamp

New changeset 02fb78edcc1e by Cédric Krier in branch '5.0':
Always read _timestamp
New changeset d5a8fc6859c2 by Cédric Krier in branch 'default':
Always read _timestamp
New changeset ebacaf3b0452 by Cédric Krier in branch 'default':
Always read _timestamp
msg53141 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-11-12.08:19:41
You are right, updating to 5.4.1 solved the issue.
msg53140 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-11-11.19:34:04
This should be fixed by rev 3e6a252d097b
msg53139 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-11-11.19:25:04
Can we push this? 

Currently this breaks the import_countries script on 5.4:

  File "/usr/local/bin/trytond_import_countries", line 11, in <module>
    load_entry_point('trytond-country==5.4.0', 'console_scripts', 'trytond_import_countries')()
  File "/usr/local/lib/python3.7/dist-packages/trytond/modules/country/scripts/", line 173, in run
    main(args.database, args.config_file)
  File "/usr/local/lib/python3.7/dist-packages/trytond/modules/country/scripts/", line 151, in main
  File "/usr/local/lib/python3.7/dist-packages/trytond/modules/country/scripts/", line 156, in do_import
    countries = update_countries(countries)
  File "/usr/local/lib/python3.7/dist-packages/trytond/modules/country/scripts/", line 60, in update_countries
  File "/usr/local/lib/python3.7/dist-packages/proteus/", line 103, in newfunc
    return self.func(owner, *args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/proteus/", line 858, in save
  File "/usr/local/lib/python3.7/dist-packages/proteus/", line 188, in __call__
    result = rpc.result(meth(*args, **kwargs))
  File "/usr/local/lib/python3.7/dist-packages/trytond/modules/country/", line 84, in write
    super(Country, cls).write(*args)
  File "/usr/local/lib/python3.7/dist-packages/trytond/model/", line 159, in wrapper
    return func(cls, *args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/trytond/model/", line 951, in write
  File "/usr/local/lib/python3.7/dist-packages/trytond/model/", line 551, in __check_timestamp
    'Records were modified in the meanwhile')
trytond.exceptions.ConcurrencyException: Records were modified in the meanwhile
review268331002 updated at
msg53027 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-11-04.23:07:32
Since r 879829bc1534, the _timestamp are not loaded as _fields is always not empty.
The other clients always read the timestamp to be sure to always have the last value.
Date User Action Args
2019-11-24 20:52:05roundup-botsetmessages: + msg53463
keyword: - backport
2019-11-16 12:47:11roundup-botsetmessages: + msg53244
2019-11-16 12:47:07roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg53243
2019-11-12 08:19:41pokolisetmessages: + msg53141
2019-11-11 19:34:04cedsetmessages: + msg53140
2019-11-11 19:25:04pokolisetnosy: + pokoli
messages: + msg53139
2019-11-08 17:43:13pokolisetkeyword: + backport
2019-11-04 23:35:15reviewbotsetnosy: + reviewbot
messages: + msg53028
2019-11-04 23:08:13cedsetstatus: in-progress -> testing
reviews: 268331002
keyword: + review
2019-11-04 23:07:32cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)