Tryton - Issues

 

Issue8787

Title can't seem to edit maturity date on moves
Priority bug Status resolved
Superseder Do not write on target already added to One2Many
View: 9194
Nosy List ced, pokoli, reviewbot, risto3, roundup-bot
Type behavior Components account
Assigned To pokoli Keywords review
Reviews 286381004
View: 286381004

Created on 2019-11-03.15:53:30 by risto3, last changed by roundup-bot.

Messages
New changeset a825c6456c1e by Sergi Almacellas Abellana in branch 'default':
Add lines on Move's check_modify_exclude
https://hg.tryton.org/tryton-env/rev/a825c6456c1e
New changeset f8d219211cc1 by Sergi Almacellas Abellana in branch 'default':
Add lines on Move's check_modify_exclude
https://hg.tryton.org/modules/account/rev/f8d219211cc1
review286381004 updated at https://codereview.tryton.org/286381004/#ps293671002
msg57931 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-05-10.13:41:28
I've implmented issue9194 and updated the review to require it.

Everything is not ready to be tested.
msg56812 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-04-01.00:48:19
Indeed I think we should implement issue9194 so it will not be needed to exclude move.
msg54425 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-12-10.23:09:05
On 2019-12-10 19:42, Sergi Almacellas Abellana wrote:
> Indeed it was also required to exclude the move from the lines modification as the field is rewritten by the clients.

Then it is a no go. We can not allow to modify the move of a posted
line.
New review286381004 at https://codereview.tryton.org/286381004/#ps254741006
msg54422 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-12-10.19:42:31
Here is review286381004 that fixes it. 

Indeed it was also required to exclude the move from the lines modification as the field is rewritten by the clients.
msg53012 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-11-03.16:35:35
On from move form but not on line. lines should probably be added to Move._check_modify_exclude as check_modify is called by the lines at creation and deletion.
msg53011 (view) Author: [hidden] (risto3) Date: 2019-11-03.15:53:29
as this apparently was possible with https://bugs.tryton.org/issue7276
I get an exception if I try to save a move with the maturity date updated on a line. The message is to the tune 'you cannot modify a posted move " 16429 "'
I'm using the 5.2 tryton gtk client.
History
Date User Action Args
2020-06-17 14:00:17roundup-botsetmessages: + msg58761
2020-06-17 14:00:13roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg58760
2020-05-10 14:00:54reviewbotsetmessages: + msg57933
2020-05-10 13:41:28pokolisetstatus: chatting -> testing
assignedto: pokoli
messages: + msg57931
2020-04-01 00:48:19cedsetsuperseder: + Do not write on target already added to One2Many
messages: + msg56812
2020-03-13 00:35:27cedsetstatus: in-progress -> chatting
2019-12-11 09:48:27pokolisetstatus: testing -> in-progress
assignedto: pokoli -> (no value)
2019-12-10 23:09:06cedsetmessages: + msg54425
2019-12-10 19:56:57reviewbotsetnosy: + reviewbot
messages: + msg54423
2019-12-10 19:56:56reviewbotsetreviews: 286381004
keyword: + review
2019-12-10 19:42:31pokolisetstatus: chatting -> testing
assignedto: pokoli
messages: + msg54422
nosy: + pokoli
2019-11-03 16:35:36cedsetstatus: unread -> chatting
type: behavior
messages: + msg53012
nosy: + ced
2019-11-03 15:53:30risto3create