Tryton - Issues

 

Issue8642

Title Add limit to user preference actions
Priority feature Status testing
Superseder Nosy List albertcuni, ced, pokoli, reviewbot
Type behavior Components trytond
Assigned To pokoli Keywords easy, review
Reviews 317131002
View: 317131002

Created on 2019-09-06.17:13:34 by ced, last changed by reviewbot.

Messages
review317131002 updated at https://codereview.tryton.org/317131002/#ps291411002
msg56956 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2020-04-09.23:48:09
I'm wondering if we really need to make it configurable with config file. Indeed it will be quite easy to increase the limit with a custom module. I think it is good to keep configuration options as small as possible.
review317131002 updated at https://codereview.tryton.org/317131002/#ps295351002
review317131002 updated at https://codereview.tryton.org/317131002/#ps309241002
msg56872 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2020-04-03.13:52:19
Here is review317131002 which implements it!
msg51675 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-09-06.17:13:33
Last day, someone on the demo server set all the actions on the admin preference. This made impossible to login as admin as the client starts to open all the actions which consume a lot of resources.
I think it will be a good safety measure to set a limit for example 5 but make it configurable.
History
Date User Action Args
2020-04-10 16:04:36reviewbotsetmessages: + msg56962
2020-04-09 23:48:09cedsetmessages: + msg56956
2020-04-09 18:01:29reviewbotsetmessages: + msg56953
2020-04-03 14:14:21reviewbotsetnosy: + reviewbot
messages: + msg56873
2020-04-03 13:52:20pokolisetstatus: unread -> testing
keyword: + review
nosy: + pokoli
messages: + msg56872
reviews: 317131002
assignedto: albertcuni -> pokoli
2020-04-01 10:45:56albertcunisetassignedto: albertcuni
nosy: + albertcuni
2019-09-06 17:13:34cedcreate