Tryton - Issues

 

Issue8551

Title When the state of a task is set to 'done' set also an enddate
Priority feature Status chatting
Superseder Allow complete freedom on project and task states
View: 7746
Nosy List ced, edbo, pokoli, reviewbot
Type Components project
Assigned To Keywords review
Reviews 251961002
View: 251961002

Created on 2019-08-01.15:28:49 by edbo, last changed by pokoli.

Messages
New review251961002 at https://codereview.tryton.org/251961002/#ps270051011
msg51012 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-08-01.15:49:55
At some point, I think it should be related to issue7746.
But for me, it is not clear which date should be set. Maybe the field should just be required when going to a "ending" state.
msg51009 (view) Author: [hidden] (edbo) Date: 2019-08-01.15:28:48
When a task is completed on a project the state is set to done. But when on the task the 'timesheet_available' is checked the 'timesheet_end_date' should also be set. Because it doesn't make sense and IMO is wrong the user is still able to add timesheet lines to a work which already been set to done.

The question is: should I create a on_change_state function or add the end date on validation? Personally I prefer to add the date with the on_change.
History
Date User Action Args
2019-08-08 12:21:56pokolisetnosy: ced, pokoli, reviewbot, edbo
2019-08-02 20:42:34reviewbotsetnosy: + reviewbot
messages: + msg51037
2019-08-02 20:42:34reviewbotsetreviews: 251961002
keyword: + review
2019-08-02 10:08:17pokolisetnosy: + pokoli
2019-08-01 15:49:55cedsetstatus: unread -> chatting
superseder: + Allow complete freedom on project and task states
messages: + msg51012
nosy: + ced
2019-08-01 15:28:49edbocreate

Showing 10 items. Show all history (warning: this could be VERY long)