Tryton - Issues

 

Issue8474

Title Wrong PYSON domain validation when grouped record > IN_MAX
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type behavior Components trytond
Assigned To ced Keywords backport, review
Reviews 257701002
View: 257701002

Created on 2019-07-04.21:29:54 by ced, last changed by ced.

Messages
New changeset dd78f5f86124 by Cédric Krier in branch 'default':
Use non grouped domain when grouped record > IN_MAX
https://hg.tryton.org/tryton-env/rev/dd78f5f86124
New changeset e4a93fc51560 by Cédric Krier in branch 'default':
Ensure count of grouped_slice is at least 1
https://hg.tryton.org/trytond/rev/e4a93fc51560

New changeset 4f54d7c7dc50 by Cédric Krier in branch 'default':
Use non grouped domain when grouped record > IN_MAX
https://hg.tryton.org/trytond/rev/4f54d7c7dc50

New changeset 18ff0e067a0a by Cédric Krier in branch 'default':
Test unique pyson domain validation with greater IN_MAX
https://hg.tryton.org/trytond/rev/18ff0e067a0a
review257701002 updated at https://codereview.tryton.org/257701002/#ps271731002
msg50511 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-07-04.21:32:57
Here is review257701002 (which contains also a fix when count of grouped_slice is zero (result of integer division)).
msg50510 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-07-04.21:29:53
The validation fails (the invalid value can be found valid or valid value can be found invalid) when the validation groups more than IN_MAX record because the break operator stop only the first loop so a partial grouped domain is used.
History
Date User Action Args
2019-07-13 00:27:19cedsetkeyword: + backport
2019-07-13 00:12:07roundup-botsetmessages: + msg50646
2019-07-13 00:11:47roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg50645
2019-07-04 21:48:47reviewbotsetnosy: + reviewbot
messages: + msg50512
2019-07-04 21:32:57cedsetstatus: in-progress -> testing
reviews: 257701002
messages: + msg50511
keyword: + review
2019-07-04 21:29:54cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)