Tryton - Issues

 

Issue8462

Title queue print_invoice
Priority feature Status testing
Superseder Nosy List ced, lukio, pokoli, resteve, reviewbot, yangoon
Type feature request Components account_invoice
Assigned To lukio Keywords review
Reviews 277531002
View: 277531002

Created on 2019-06-28.23:04:36 by lukio, last changed by ced.

Messages
msg50478 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-06-30.20:33:08
For me, the main danger is that if the task fails and nobody print the invoice in a short time. We do not have a cached version of the report for archive.
So for me, we need a way to ensure that such invoice will be archived. Maybe it can be with a cron task.
msg50472 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-06-29.12:06:21
I'm not sure if this has to be at the base module or it can be done in a custom module. 

We have some implementations that use the notification_email module to send the invoice to the customer when posting it. I'm not sure if this will work with the queue. This is the same as https://codereview.tryton.org/277531002#msg3


BTW: Have you tried to implement this behaviour in a custom module?
msg50470 (view) Author: [hidden] (resteve) Date: 2019-06-28.23:51:34
IMHO the expensive task is get the number because is a sequence strict when post mĂșltiples invoices

We developed a custom post_single method that is called by queue: get number and print invoice. In case has an error, send the traceback by E-mail (example, period not defined or clossed, number consecutive by date (required in Spain) etc... (current versions 5.x could send by notify client)
New review277531002 at https://codereview.tryton.org/277531002/#ps275671002
msg50467 (view) Author: [hidden] (lukio) Date: 2019-06-28.23:11:29
Added a review code: https://codereview.tryton.org/277531002
msg50466 (view) Author: [hidden] (lukio) Date: 2019-06-28.23:04:35
print_invoice is an expensive task, so it could be nice to add it to a queue.

For example, when we need to post a lot of invoices created by sale_subscription module.
History
Date User Action Args
2019-06-30 20:34:16cedsetcomponent: + account_invoice
2019-06-30 20:33:08cedsetnosy: + ced
messages: + msg50478
2019-06-30 20:26:52cedsetpriority: wish -> feature
2019-06-29 12:06:21pokolisetnosy: + pokoli
messages: + msg50472
2019-06-29 00:42:47yangoonsetnosy: + yangoon
2019-06-28 23:51:34restevesetnosy: + resteve
messages: + msg50470
2019-06-28 23:20:06reviewbotsetnosy: + reviewbot
messages: + msg50468
2019-06-28 23:20:06reviewbotsetreviews: 277531002
keyword: + review
2019-06-28 23:11:29lukiosetstatus: in-progress -> testing
messages: + msg50467
2019-06-28 23:04:36lukiocreate

Showing 10 items. Show all history (warning: this could be VERY long)