Tryton - Issues

 

Issue8440

Title Use a single btn styling class on wizard buttons
Priority feature Status testing
Superseder Nosy List dave, reviewbot
Type behavior Components sao
Assigned To dave Keywords review
Reviews 261721002
View: 261721002

Created on 2019-06-18.20:12:44 by dave, last changed by reviewbot.

Messages
New review261721002 at https://codereview.tryton.org/261721002/#ps285421002
New review255611002 at https://codereview.tryton.org/255611002/#ps261671002
msg50315 (view) Author: [hidden] (dave) Date: 2019-06-18.20:12:44
When opening a wizard on Sao the default button has both "btn-default" and "btn-primary" classes, and cancel buttons have both "btn-link" and "btn-default" classes.

From the examples I have seen it doesn't seem to make sense for a button to have more than one of the button styles (default, primary, success, info, warning, danger, or link).

So, it would make sense to remove the "btn-default" class from the buttons when the "btn-link" or "btn-primary" class is added.
History
Date User Action Args
2019-06-25 13:47:25reviewbotsetmessages: + msg50381
2019-06-25 13:47:25reviewbotsetreviews: 261721002
2019-06-25 13:41:48davesetreviews: 255611002 -> (no value)
2019-06-19 00:07:02reviewbotsetnosy: + reviewbot
messages: + msg50320
2019-06-19 00:07:01reviewbotsetreviews: 255611002
keyword: + review
2019-06-18 23:48:11davesetstatus: unread -> testing
assignedto: dave
2019-06-18 20:13:24davesettitle: Multiple btn styling classes on wizard buttons -> Use a single btn styling class on wizard buttons
2019-06-18 20:12:44davecreate

Showing 10 items. Show all history (warning: this could be VERY long)