Tryton - Issues

 

Issue8416

Title Icon colors in GTK-client cannot be set through tryton.conf anymore
Priority bug Status resolved
Superseder Nosy List ced, edbo, reviewbot, roundup-bot
Type behavior Components tryton
Assigned To ced Keywords review
Reviews 257601002
View: 257601002

Created on 2019-06-10.17:42:16 by edbo, last changed by roundup-bot.

Messages
New changeset 27034d04fb31 by Cédric Krier in branch '5.2':
Do not store colors on IconFactory
https://hg.tryton.org/tryton/rev/27034d04fb31
New changeset 912e8223aaf9 by Cédric Krier in branch 'default':
Do not store colors on IconFactory
https://hg.tryton.org/tryton-env/rev/912e8223aaf9
New changeset 02574ae24a1d by Cédric Krier in branch 'default':
Do not store colors on IconFactory
https://hg.tryton.org/tryton/rev/02574ae24a1d
msg50293 (view) Author: [hidden] (edbo) Date: 2019-06-17.10:46:45
Thanks! The change indeed fixes the colors.
review257601002 updated at https://codereview.tryton.org/257601002/#ps271581002
msg50252 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-06-16.10:28:28
Here is review257601002 that should fix the behavior.
msg50169 (view) Author: [hidden] (edbo) Date: 2019-06-10.17:42:15
In version 5.0 I am able to set the icon colors through my ~/.config/tryton/5.0/tryton.conf. I set for example
[icon]
color = #ff00ff

I noticed that in version 5.2 the name 'color' was changed to 'colors' and has 3 colors instead of one (for the badges). So I changed the configuration accordingly. But it's not working.

It seems that the colors with the start of the client already been read from the defaults before the tryton.conf is read. Can http://hg.tryton.org/tryton/rev/65aff6f1a7e9#l2.7 be the culprit? I just added a print statement underneath and it showed up as the first message in the terminal.
History
Date User Action Args
2019-06-25 23:26:06roundup-botsetmessages: + msg50396
2019-06-20 23:18:34roundup-botsetmessages: + msg50346
2019-06-20 23:18:32roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg50345
2019-06-17 10:46:46edbosetmessages: + msg50293
2019-06-16 10:47:37reviewbotsetnosy: + reviewbot
messages: + msg50254
2019-06-16 10:28:28cedsetstatus: unread -> testing
keyword: + review
nosy: + ced
messages: + msg50252
reviews: 257601002
assignedto: ced
type: behavior
2019-06-10 17:42:16edbocreate

Showing 10 items. Show all history (warning: this could be VERY long)