Tryton - Issues

 

Issue8391

Title account_fr migration to 5.2
Priority bug Status invalid
Superseder Do not display closed account on GL
View: 8491
Nosy List ced, pokoli, risto3
Type Components account_fr
Assigned To Keywords
Reviews

Created on 2019-06-01.13:16:50 by risto3, last changed by ced.

Messages
msg50653 (view) Author: [hidden] (risto3) Date: 2019-07-13.09:12:47
?? That's primarily what I filed as issue! 

The only way I could keep the erroneous account (445500) from displaying and fouling the balance was by setting the type to 'None'.  

NB: all values for the closed account 445500 are erroneous 
(and consequently, by inspection, all values for any closed account with a type
and child accounts having values)

In addition, there are other accounts that need to be set to 'closed' and type to None, such as 401 (or 401000 at 6 digits).

Or just to 'closed' such as the 42
A borderline case is with, for example, 421 ... which is closed by default.

This should probably *not* be closed by default as it is seemingly not an obligation to use subaccounts for employees if parties are used for them (like we, and probably most, do).

I can only provide an exhaustive list for what caused us problems once migration to 5.2 is completed... which isn't probably for a few weeks yet to overcome these kinds of issues. 

Anybody else having the French PCG in production with a 2+ fiscal years should have come across this (it's noticeable with a single fiscal year, but flagrant with more)
msg50643 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-07-13.00:00:23
I invalidate this issue because there is nothing wrong with the migration, it is just that closed account are displayed on GL.
msg50640 (view) Author: [hidden] (risto3) Date: 2019-07-12.23:25:24
Elementary accounting...

1. for every column of 445500, the value should be the cumulation (view) of the children cells (44551+44558)
   it clearly is not as the beginning balance of 445500 is wrong as are the debit/credit/end balances.

2. in simple balance that tryton presents, values in what used to be views were not displayed or at least not taken into 
   account for in the balance, but now they are... which is wrong and inexploitable.

445500 should probably not be present at all unless it becomes possible to display usefully without affecting the total balance on the report output.

cheers
msg50636 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-07-12.19:43:10
I do not understand what msg50635 tries to show.

4455 was a 'view' and now is closed (correct)
http://hg.tryton.org/modules/account_fr/file/5.0/account_fr.xml#l5849
http://hg.tryton.org/modules/account_fr/file/5.2/account_fr.xml#l5177

44551 had a kind of 'other' and now has just a type (correct)
http://hg.tryton.org/modules/account_fr/file/5.0/account_fr.xml#l5855
http://hg.tryton.org/modules/account_fr/file/5.2/account_fr.xml#l5184

44558 has a kind of 'other' and now has just a type (correct)
http://hg.tryton.org/modules/account_fr/file/5.0/account_fr.xml#l5863
http://hg.tryton.org/modules/account_fr/file/5.2/account_fr.xml#l5190

If you do not show complete explanation of the problem, we will not be able to fix it (if there is one).
Also in the explanation, please reproduce the problem with only standard modules.
msg50635 (view) Author: [hidden] (risto3) Date: 2019-07-12.19:27:33
? 
The example given is the 445. tree! (In SQL this is 445%)

Here is an example of erroneous output in GL after upgrading:
"445500"	"Taxes sur le chiffre d'affaires à décaisser"	"12 313,00"	"0,00"	"0,00"	"-5 746,00"
"445510"	"T.V.A. à décaisser"	"0,00"	"50 772,00"	"68 831,00"	"-18 059,00"
"445580"	"Taxes assimilées à la T.V.A."	"0,00"	"0,00"	"0,00"	"0,00"

And this is N-1:
"445500"	"Taxes sur le chiffre d'affaires à décaisser"	"0,00"	"0,00"	"0,00"	"12 313,00"
"445510"	"T.V.A. à décaisser"	"-12 313,00"	"175 801,00"	"163 488,00"	"0,00"
"445580"	"Taxes assimilées à la T.V.A."	"0,00"	"0,00"	"0,00"	"0,00"

unexploitable...

(BTW - we use account_code_digits, updated for fr and for 5.2, set to 6)
msg50249 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-06-16.10:00:30
The only example given is 445 which has not type so it is not available for move line.
msg49937 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-06-03.09:12:35
Could you provide the list of wrong accounts and their proper values?

thanks
msg49935 (view) Author: [hidden] (risto3) Date: 2019-06-01.13:16:50
There are numerous accounts, of the previous 'view' kind, that need either to be 'closed' or have their type set to None, or both.

The bad effect is in the balance or general ledger these are displayed with, furthermore with inexact values.

An good example is in the 445. tree...
But in all, I have many dozens to correct manually.
History
Date User Action Args
2019-07-13 09:45:09cedsetstatus: chatting -> invalid
2019-07-13 09:12:47risto3setstatus: invalid -> chatting
messages: + msg50653
2019-07-13 00:00:24cedsetstatus: chatting -> invalid
superseder: + Do not display closed account on GL
messages: + msg50643
2019-07-12 23:25:24risto3setstatus: need-eg -> chatting
messages: + msg50640
2019-07-12 19:43:11cedsetstatus: chatting -> need-eg
messages: + msg50636
2019-07-12 19:27:33risto3setstatus: invalid -> chatting
messages: + msg50635
2019-06-16 10:00:30cedsetstatus: chatting -> invalid
nosy: + ced
messages: + msg50249
2019-06-03 09:12:35pokolisetstatus: unread -> chatting
nosy: + pokoli
messages: + msg49937
2019-06-01 13:16:50risto3create