Tryton - Issues

 

Issue8167

Title Too much fields_view_get calls
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type behavior Components sao
Assigned To ced Keywords review
Reviews 60581002
View: 60581002

Created on 2019-03-04.10:23:35 by ced, last changed by roundup-bot.

Messages
New changeset c6d4386ad622 by Cédric Krier in branch '5.0':
Remove unnecessary calls to fields_view_get
https://hg.tryton.org/sao/rev/c6d4386ad622
New changeset 622c14fdcde1 by Cédric Krier in branch 'default':
Remove unnecessary calls to fields_view_get
https://hg.tryton.org/tryton-env/rev/622c14fdcde1
New changeset 46f47d631ee2 by Cédric Krier in branch 'default':
Remove unnecessary calls to fields_view_get
https://hg.tryton.org/sao/rev/46f47d631ee2
review60581002 updated at https://codereview.tryton.org/60581002/#ps1
msg47373 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-03-04.10:23:34
I discover that sao makes too much calls to fields_view_get. For example, when opening the list of party it calls fields_view_get for the form view of the party but also for the address, category etc. It also calls fields_view_get with no ids for the domain_parser.
I put the priority as bug, because I think it may introduce side effect compared to tryton that may lead to different behavior. So fix should be back-ported.
History
Date User Action Args
2019-03-24 15:38:25roundup-botsetmessages: + msg47968
2019-03-15 11:14:35roundup-botsetmessages: + msg47592
2019-03-15 11:14:33roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg47591
2019-03-04 10:41:26reviewbotsetnosy: + reviewbot
messages: + msg47375
2019-03-04 10:26:48cedsetstatus: in-progress -> testing
reviews: 60581002
keyword: + review
2019-03-04 10:23:35cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)