Tryton - Issues

 

Issue8141

Title Unable to search order points by location
Priority bug Status resolved
Superseder Nosy List pokoli, reviewbot, roundup-bot
Type crash Components stock_supply
Assigned To pokoli Keywords review
Reviews 58531002
View: 58531002

Created on 2019-02-22.19:27:55 by pokoli, last changed by roundup-bot.

Messages
New changeset 226e45e1e9fc by Sergi Almacellas Abellana in branch '5.0':
Use OR clauses on location searcher
https://hg.tryton.org/modules/stock_supply/rev/226e45e1e9fc

New changeset 104413718ffd by Sergi Almacellas Abellana in branch '4.8':
Use OR clauses on location searcher
https://hg.tryton.org/modules/stock_supply/rev/104413718ffd

New changeset 35b587f2a689 by Sergi Almacellas Abellana in branch '4.6':
Use OR clauses on location searcher
https://hg.tryton.org/modules/stock_supply/rev/35b587f2a689

New changeset cac8a60c084c by Sergi Almacellas Abellana in branch '4.4':
Use OR clauses on location searcher
https://hg.tryton.org/modules/stock_supply/rev/cac8a60c084c

New changeset ffe683caf404 by Sergi Almacellas Abellana in branch '4.2':
Use OR clauses on location searcher
https://hg.tryton.org/modules/stock_supply/rev/ffe683caf404
New changeset d45cc934ef7a by Sergi Almacellas Abellana in branch 'default':
Use OR clauses on location searcher
https://hg.tryton.org/tryton-env/rev/d45cc934ef7a
New changeset b5dff78398eb by Sergi Almacellas Abellana in branch 'default':
Use OR clauses on location searcher
https://hg.tryton.org/modules/stock_supply/rev/b5dff78398eb

New changeset 67433b35ecf5 by Sergi Almacellas Abellana in branch 'default':
Add test for order point location's searcher
https://hg.tryton.org/modules/stock_supply/rev/67433b35ecf5
review58531002 updated at https://codereview.tryton.org/58531002/#ps20001
review58531002 updated at https://codereview.tryton.org/58531002/#ps1
msg47164 (view) Author: [hidden] (pokoli) (Tryton committer) Date: 2019-02-22.19:27:55
When searching an order point by it's location i get the following traceback:

Traceback (most recent call last):
  File "/trytond/wsgi.py", line 78, in dispatch_request
    return endpoint(request, **request.view_args)
  File "/trytond/protocols/dispatcher.py", line 48, in rpc
    request, database_name, *request.rpc_params)
  File "/trytond/wsgi.py", line 49, in auth_required
    return wrapped(*args, **kwargs)
  File "/trytond/protocols/wrappers.py", line 131, in wrapper
    return func(request, pool, *args, **kwargs)
  File "/trytond/protocols/dispatcher.py", line 186, in _dispatch
    result = rpc.result(meth(*c_args, **c_kwargs))
  File "/trytond/model/modelsql.py", line 1196, in search
    tables, expression = cls.search_domain(domain)
  File "/trytond/model/modelsql.py", line 1380, in search_domain
    expression = convert(domain)
  File "/trytond/model/modelsql.py", line 1378, in convert
    domain[1:] if domain[0] == 'AND' else domain)))
  File "/trytond/model/modelsql.py", line 1377, in <genexpr>
    return And((convert(d) for d in (
  File "/trytond/model/modelsql.py", line 1368, in convert
    expression = field.convert_domain(domain, tables, cls)
  File "/trytond/model/fields/function.py", line 79, in convert_domain
    return getattr(Model, self.searcher)(self.name, domain)
  File "/trytond/modules/stock_supply/order_point.py", line 244, in search_location
    for _, operator, operand in domain:
ValueError: too many values to unpack (expected 3)
History
Date User Action Args
2019-03-24 15:38:06roundup-botsetmessages: + msg47966
2019-03-15 17:51:03roundup-botsetmessages: + msg47654
2019-03-15 17:50:51roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg47653
2019-02-28 19:42:32reviewbotsetmessages: + msg47268
2019-02-22 19:35:31reviewbotsetnosy: + reviewbot
messages: + msg47167
2019-02-22 19:28:19pokolisetstatus: in-progress -> testing
reviews: 58531002
keyword: + review
2019-02-22 19:27:55pokolicreate