Tryton - Issues

 

Issue8131

Title Views currently interwind the code constructing views and parsing the XML
Priority feature Status resolved
Superseder Nosy List ced, nicoe, reviewbot, roundup-bot
Type performance Components sao, tryton
Assigned To ced Keywords review
Reviews 54561002
View: 54561002

Created on 2019-02-19.19:17:50 by nicoe, last changed by roundup-bot.

Messages
New changeset be9af7fadd38 by Cédric Krier in branch 'default':
Convert height and width attributes into integer
https://hg.tryton.org/tryton-env/rev/be9af7fadd38
New changeset 76cb0a4ce570 by Cédric Krier in branch 'default':
Convert height and width attributes into integer
https://hg.tryton.org/tryton/rev/76cb0a4ce570
New changeset 5abafe02b70c by Cédric Krier in branch 'default':
Convert height and width attributes into integer
https://hg.tryton.org/sao/rev/5abafe02b70c
New changeset 319fd7d40496 by Cédric Krier in branch 'default':
Add missing implementation of get_fields on views
https://hg.tryton.org/tryton-env/rev/319fd7d40496
New changeset 8936df2acecf by Cédric Krier in branch 'default':
Add missing implementation of get_fields on views
https://hg.tryton.org/sao/rev/8936df2acecf
New changeset 1278c55f5840 by Cédric Krier in branch 'default':
Use separate XML parser in Views
https://hg.tryton.org/tryton-env/rev/1278c55f5840
New changeset e8ffb2b2e722 by Cédric Krier in branch 'default':
Use separate XML parser in Views
https://hg.tryton.org/tryton/rev/e8ffb2b2e722
New changeset 2fc36d9e359b by Cédric Krier in branch 'default':
Use separate XML parser in Views
https://hg.tryton.org/sao/rev/2fc36d9e359b
review54561002 updated at https://codereview.tryton.org/54561002/#ps277071002
review54561002 updated at https://codereview.tryton.org/54561002/#ps255091004
review54561002 updated at https://codereview.tryton.org/54561002/#ps140001
review54561002 updated at https://codereview.tryton.org/54561002/#ps120001
review54561002 updated at https://codereview.tryton.org/54561002/#ps100001
review54561002 updated at https://codereview.tryton.org/54561002/#ps80001
review54561002 updated at https://codereview.tryton.org/54561002/#ps60001
review54561002 updated at https://codereview.tryton.org/54561002/#ps40001
msg47124 (view) Author: [hidden] (nicoe) (Tryton committer) Date: 2019-02-19.19:17:50
It can be cumbersome to reuse the code of ViewForm, ViewTree, etc because the code currently interwinds the code required to parse the XML and the one constructing the view per se.

The review factorize the XML parsing code out.
History
Date User Action Args
2019-05-05 19:51:14roundup-botsetmessages: + msg49629
2019-05-05 19:51:12roundup-botsetmessages: + msg49627
2019-05-05 19:51:08roundup-botsetmessages: + msg49625
2019-03-13 19:30:23roundup-botsetmessages: + msg47580
2019-03-13 19:30:19roundup-botsetmessages: + msg47579
2019-03-11 12:03:18roundup-botsetmessages: + msg47546
2019-03-11 12:03:16roundup-botsetmessages: + msg47545
2019-03-11 12:03:13roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg47544
2019-03-08 16:45:15reviewbotsetmessages: + msg47480
2019-03-08 16:33:41cedsetstatus: chatting -> testing
assignedto: nicoe -> ced
nosy: + ced

Showing 10 items. Show all history (warning: this could be VERY long)