Tryton - Issues

 

Issue8006

Title Empty rows in Export data csv file
Priority bug Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot, smarro, smn
Type behavior Components tryton
Assigned To ced Keywords Python3, review
Reviews 269131002
View: 269131002

Created on 2019-01-17.00:04:47 by smarro, last changed by roundup-bot.

Files
File name Uploaded Type Edit Remove
products.csv smn, 2019-03-13.15:26:07 text/csv
Messages
New changeset f5454c8aeab9 by Cédric Krier in branch '5.0':
Open CSV file with empty newline
https://hg.tryton.org/tryton/rev/f5454c8aeab9
New changeset 5d4f2d701929 by Cédric Krier in branch 'default':
Open CSV file with empty newline
https://hg.tryton.org/tryton-env/rev/5d4f2d701929
New changeset 841e8f907d37 by Cédric Krier in branch 'default':
Open CSV file with empty newline
https://hg.tryton.org/tryton/rev/841e8f907d37
msg47577 (view) Author: [hidden] (smn) Date: 2019-03-13.18:19:39
LGTM
review269131002 updated at https://codereview.tryton.org/269131002/#ps257151002
msg47571 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-03-13.16:24:20
Here is review269131002 which should fix the problem. The newline management of Python3 is in conflict with the csv module.
msg47568 (view) Author: [hidden] (smn) Date: 2019-03-13.15:26:07
File example attached.
We are talking always about Windows environment, no UNIX systems involved.
msg47566 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-03-13.14:23:48
Could you provide an example of the file?
On windows it is normal that lines ends with '\r\n'. So if you open on UNIX a CSV file generated from Windows, you will have extra lines.
msg45996 (view) Author: [hidden] (smarro) Date: 2019-01-17.00:04:46
Using Windows client (5.0.3), when export data, the generated csv file has a empty row before each record.
History
Date User Action Args
2019-03-28 19:58:08roundup-botsetmessages: + msg48106
2019-03-22 11:21:08roundup-botsetmessages: + msg47767
2019-03-22 11:21:07roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg47766
2019-03-13 18:19:39smnsetmessages: + msg47577
2019-03-13 16:40:05reviewbotsetnosy: + reviewbot
messages: + msg47572
2019-03-13 16:24:21cedsetstatus: in-progress -> testing
reviews: 269131002
messages: + msg47571
keyword: + review
2019-03-13 16:22:17cedsetstatus: need-eg -> in-progress
assignedto: ced
type: behavior
keyword: + Python3
2019-03-13 15:26:07smnsetfiles: + products.csv
nosy: + smn
messages: + msg47568
2019-03-13 14:23:49cedsetstatus: unread -> need-eg
nosy: + ced
messages: + msg47566
2019-01-17 00:04:47smarrocreate

Showing 10 items. Show all history (warning: this could be VERY long)