Tryton - Issues

 

Issue7985

Title Opening a record from a one2many that is in readonly mode shows record on edit mode
Priority bug Status testing
Superseder Nosy List Timitos, brunnenschacht, ced, pokoli, reviewbot
Type behavior Components trytond
Assigned To ced Keywords review
Reviews 265101002
View: 265101002

Created on 2019-01-11.12:32:07 by Timitos, last changed by reviewbot.

Files
File name Uploaded Type Edit Remove
jys8o-81mq4.webm brunnenschacht, 2019-03-15.08:53:33 video/webm
Messages
New review265101002 at https://codereview.tryton.org/265101002/#ps253141002
msg47660 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-03-15.19:48:24
Here is review265101002 which raises NotImplemetedError when value is set on Function field without setter.
It requires to modify proteus to behaves like the clients following issue6256.
It requires to modify many One2Many Function field into Many2Many to avoid setting value even if it is readonly. And to modify some scenario or tests to force setting readonly fields.
msg47588 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-03-15.09:20:14
Well the client behaves correctly because it send the write operation but the invoices field is a function field without a setter so nothing happens.
I think we should raise an error in such case.
msg47587 (view) Author: [hidden] (brunnenschacht) Date: 2019-03-15.08:53:33
I have a similar problem maybe the same. I attached a video. I use Tryton Client 5.0.6 with the demo server. The same thing happens with the admin user to.
msg47500 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-03-08.19:11:52
Readonly One2Many are send on save see issue6256. So for me, it is valid.
msg45917 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-01-11.16:45:43
But issue7824 is also backported to 5.0 series, so it should affect also 5.0 series. Is the issue correct?
msg45910 (view) Author: [hidden] (Timitos) Date: 2019-01-11.12:32:07
When i open an invoice record from the one2many on purchase form view then the invoice form is opened in edit mode instead of readonly mode.

This is irritating as it is possible to edit fields in this form and if the form is close by clicking on the "OK" button the entered values are lost.

This happens in 5.0 but not on trunk because of issue7824.
History
Date User Action Args
2019-03-15 20:11:07reviewbotsetnosy: + reviewbot
messages: + msg47662
2019-03-15 20:11:06reviewbotsetreviews: 265101002
keyword: + review
2019-03-15 19:48:24cedsetstatus: chatting -> testing
assignedto: ced
messages: + msg47660
2019-03-15 09:20:14cedsetcomponent: + trytond
messages: + msg47588
2019-03-15 08:53:33brunnenschachtsetfiles: + jys8o-81mq4.webm
status: invalid -> chatting
messages: + msg47587
nosy: + brunnenschacht
2019-03-08 19:11:53cedsetstatus: chatting -> invalid
nosy: + ced
messages: + msg47500
2019-01-11 16:45:44pokolisetstatus: unread -> chatting
nosy: + pokoli
messages: + msg45917
2019-01-11 12:32:07Timitoscreate