Tryton - Issues

 

Issue7985

Title Opening a record from a one2many that is in readonly mode shows record on edit mode
Priority bug Status resolved
Superseder Nosy List Timitos, brunnenschacht, ced, pokoli, reviewbot, roundup-bot
Type behavior Components trytond
Assigned To ced Keywords review
Reviews 265101002
View: 265101002

Created on 2019-01-11.12:32:07 by Timitos, last changed by roundup-bot.

Files
File name Uploaded Type Edit Remove
jys8o-81mq4.webm brunnenschacht, 2019-03-15.08:53:33 video/webm
Messages
New changeset b249982f12b6 by Cédric Krier in branch 'default':
Add setter to stripe_customer_source and write stripe_token in scenario
https://hg.tryton.org/tryton-env/rev/b249982f12b6
New changeset 0b4eedd4352d by Cédric Krier in branch 'default':
Add setter to stripe_customer_source and write stripe_token in scenario
https://hg.tryton.org/modules/account_payment_stripe/rev/0b4eedd4352d
New changeset 56fd68155af2 by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/tryton-env/rev/56fd68155af2
New changeset 4a2fa4f484af by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/trytond/rev/4a2fa4f484af
New changeset f161a9f37679 by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/proteus/rev/f161a9f37679
New changeset de1390e5ef9c by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/modules/stock/rev/de1390e5ef9c
New changeset f50c3e8575d6 by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/modules/sale_supply_drop_shipment/rev/f50c3e8575d6
New changeset cac2ea4223f5 by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/modules/sale_advance_payment/rev/cac2ea4223f5
New changeset 6f4907434cc7 by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/modules/sale/rev/6f4907434cc7
New changeset bf074f620ce8 by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/modules/purchase_request/rev/bf074f620ce8
New changeset 9c7b7f7166cc by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/modules/purchase_invoice_line_standalone/rev/9c7b7f7166cc
New changeset 2a5671a372d5 by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/modules/purchase/rev/2a5671a372d5
New changeset 53768a62b709 by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/modules/product/rev/53768a62b709
New changeset 11edccea01d0 by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/modules/account_product/rev/11edccea01d0
New changeset 62d19cefc0d1 by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/modules/account_invoice/rev/62d19cefc0d1
New changeset 7213d9cbe5fd by Cédric Krier in branch 'default':
Raise NotImplementedError when setting Function field without setter
https://hg.tryton.org/modules/account_fr/rev/7213d9cbe5fd
New review265101002 at https://codereview.tryton.org/265101002/#ps253141002
msg47660 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-03-15.19:48:24
Here is review265101002 which raises NotImplemetedError when value is set on Function field without setter.
It requires to modify proteus to behaves like the clients following issue6256.
It requires to modify many One2Many Function field into Many2Many to avoid setting value even if it is readonly. And to modify some scenario or tests to force setting readonly fields.
msg47588 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-03-15.09:20:14
Well the client behaves correctly because it send the write operation but the invoices field is a function field without a setter so nothing happens.
I think we should raise an error in such case.
msg47587 (view) Author: [hidden] (brunnenschacht) Date: 2019-03-15.08:53:33
I have a similar problem maybe the same. I attached a video. I use Tryton Client 5.0.6 with the demo server. The same thing happens with the admin user to.
msg47500 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-03-08.19:11:52
Readonly One2Many are send on save see issue6256. So for me, it is valid.
msg45917 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-01-11.16:45:43
But issue7824 is also backported to 5.0 series, so it should affect also 5.0 series. Is the issue correct?
msg45910 (view) Author: [hidden] (Timitos) Date: 2019-01-11.12:32:07
When i open an invoice record from the one2many on purchase form view then the invoice form is opened in edit mode instead of readonly mode.

This is irritating as it is possible to edit fields in this form and if the form is close by clicking on the "OK" button the entered values are lost.

This happens in 5.0 but not on trunk because of issue7824.
History
Date User Action Args
2019-03-31 13:31:39roundup-botsetmessages: + msg48285
2019-03-31 13:31:34roundup-botsetmessages: + msg48284
2019-03-27 00:30:20roundup-botsetmessages: + msg48044
2019-03-27 00:30:18roundup-botsetmessages: + msg48043
2019-03-27 00:30:14roundup-botsetmessages: + msg48042
2019-03-27 00:30:11roundup-botsetmessages: + msg48041
2019-03-27 00:30:08roundup-botsetmessages: + msg48040
2019-03-27 00:30:06roundup-botsetmessages: + msg48039
2019-03-27 00:30:02roundup-botsetmessages: + msg48038
2019-03-27 00:29:55roundup-botsetmessages: + msg48037

Showing 10 items. Show all history (warning: this could be VERY long)