Tryton - Issues

 

Issue7940

Title Remove useless sql constraint
Priority feature Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type feature request Components account_invoice, stock_forecast
Assigned To ced Keywords review
Reviews 70471002,56521002
View: 70471002, 56521002

Created on 2018-12-21.15:51:49 by ced, last changed by roundup-bot.

Messages
New changeset 88c40ef2779d by Cédric Krier in branch 'default':
Remove useless sql constraint
https://hg.tryton.org/tryton-env/rev/88c40ef2779d
New changeset 7250342cb353 by Cédric Krier in branch 'default':
Replace SQL check on dates and quantities by domains
https://hg.tryton.org/modules/stock_forecast/rev/7250342cb353
New changeset 59d41d23e45c by Cédric Krier in branch 'default':
Remove SQL checks on invoice line type
https://hg.tryton.org/modules/account_invoice/rev/59d41d23e45c
review56521002 updated at https://codereview.tryton.org/56521002/#ps20001
review70471002 updated at https://codereview.tryton.org/70471002/#ps20001
review56521002 updated at https://codereview.tryton.org/56521002/#ps1
review70471002 updated at https://codereview.tryton.org/70471002/#ps1
msg45432 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-12-21.15:51:48
There are some sql constraints that are useless and which can be replaced by domain.
It is better to use domain because the client can provide a better UX with early error message and notification. Also sql constraints are harder to maintain.
History
Date User Action Args
2018-12-23 17:32:33roundup-botsetmessages: + msg45489
2018-12-23 17:32:29roundup-botsetmessages: + msg45488
2018-12-23 17:32:24roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg45487
2018-12-21 16:42:48reviewbotsetmessages: + msg45438
2018-12-21 16:42:42reviewbotsetmessages: + msg45437
2018-12-21 16:12:49reviewbotsetmessages: + msg45434
2018-12-21 16:12:43reviewbotsetnosy: + reviewbot
messages: + msg45433
2018-12-21 15:54:17cedlinkissue3672 superseder
2018-12-21 15:54:00cedsetstatus: in-progress -> testing
reviews: 70471002,56521002
keyword: + review
2018-12-21 15:51:49cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)