Tryton - Issues

 

Issue7936

Title Modified field in editable one2many are duplicated to focus record when save parent record
Priority bug Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot, smarro, yangoon
Type behavior Components tryton
Assigned To ced Keywords Python3, review
Reviews 46711002
View: 46711002

Created on 2018-12-19.19:34:50 by smarro, last changed by roundup-bot.

Messages
New changeset 45cdea8c7ee6 by Cédric Krier in branch '5.0':
Rely on editing property of renderer to set value
https://hg.tryton.org/tryton/rev/45cdea8c7ee6

New changeset 83726d19143a by Cédric Krier in branch '4.8':
Rely on editing property of renderer to set value
https://hg.tryton.org/tryton/rev/83726d19143a
New changeset 7b73ec8525bf by Cédric Krier in branch 'default':
Rely on editing property of renderer to set value
https://hg.tryton.org/tryton-env/rev/7b73ec8525bf
New changeset 90eb14f40b6e by Cédric Krier in branch 'default':
Rely on editing property of renderer to set value
https://hg.tryton.org/tryton/rev/90eb14f40b6e
msg46575 (view) Author: [hidden] (smarro) (Tryton translator) Date: 2019-01-29.22:04:25
Patch works ok
review46711002 updated at https://codereview.tryton.org/46711002/#ps1
msg45912 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-01-11.13:59:50
As 4.2 series already support Python3 and because it also remove a performance killer (the remove_widget callback is registered on each key press), I think we should back-port down to there.
msg45911 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-01-11.13:57:15
Here is review46711002. It shows that it is a Python3 issue and so it does not apply to sao (which has a different design for editable tree).
msg45909 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-01-11.12:13:38
I can reproduce on tryton but not on sao.
msg45513 (view) Author: [hidden] (smarro) (Tryton translator) Date: 2018-12-27.21:48:44
Reproduced the bug also in Tryton 5.0.3
msg45512 (view) Author: [hidden] (smarro) (Tryton translator) Date: 2018-12-27.21:45:54
I can reproduce the bug only in gkt client. sao works ok.
msg45407 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-12-20.12:55:10
I think I experienced similar behavior using the translation list view, setting a value from one translation and clicking on another one sets the previous value to the new selected row. 

IIRC it also affects sao.
msg45404 (view) Author: [hidden] (yangoon) Date: 2018-12-19.20:59:10
I can confirm the bug reproducing the scenario described in msg45402. 

More precisely:
- Create the two inventory lines as described
- Change the quantity in the *first* line
- Click on the second line
- Save or refresh
-> quantity in second line is set to quantity of first line.
msg45403 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-12-19.19:37:17
How can you change the value of a line without having the focus on it?
msg45402 (view) Author: [hidden] (smarro) (Tryton translator) Date: 2018-12-19.19:34:49
Tested in tryton 4.8.8

Steps to reproduce:
1. Create a new inventory with two lines and save.
2. Change quantity in one line, click and focus the other line and save. 
The quantity of the line changed is also modified in the line with focus.
History
Date User Action Args
2019-02-10 23:51:00roundup-botsetmessages: + msg46924
2019-01-30 10:31:22roundup-botsetmessages: + msg46610
2019-01-30 10:31:15roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg46609
2019-01-29 22:04:25smarrosetmessages: + msg46575
2019-01-11 14:17:04reviewbotsetnosy: + reviewbot
messages: + msg45913
2019-01-11 13:59:51cedsetmessages: + msg45912
2019-01-11 13:57:15cedsetstatus: in-progress -> testing
reviews: 46711002
messages: + msg45911
keyword: + Python3, review
2019-01-11 12:13:39cedsetstatus: chatting -> in-progress
assignedto: ced
component: - sao
messages: + msg45909
type: behavior
2018-12-27 21:48:44smarrosetmessages: + msg45513
2018-12-27 21:45:54smarrosetmessages: + msg45512
2018-12-20 12:55:11pokolisetcomponent: + sao
messages: + msg45407
nosy: + pokoli
2018-12-19 20:59:11yangoonsetnosy: + yangoon
messages: + msg45404
2018-12-19 19:37:17cedsetstatus: unread -> chatting
nosy: + ced
messages: + msg45403
2018-12-19 19:34:50smarrocreate