Tryton - Issues

 

Issue7933

Title Not all fields of TestTaxViewResult get computed by TestTax Wizard
Priority bug Status resolved
Superseder Nosy List Timitos, ced, reviewbot, roundup-bot
Type behavior Components account
Assigned To ced Keywords easy, review
Reviews 62421003
View: 62421003

Created on 2018-12-17.21:31:44 by Timitos, last changed by roundup-bot.

Messages
New changeset 6916f5065fde by Cédric Krier in branch 'default':
Remove sign and code from tax test result and add missing legal notice
https://hg.tryton.org/tryton-env/rev/6916f5065fde
New changeset 9a9d55047b05 by Cédric Krier in branch 'default':
Remove sign and code from tax test result and add missing legal notice
https://hg.tryton.org/modules/account/rev/9a9d55047b05
review62421003 updated at https://codereview.tryton.org/62421003/#ps1
msg46757 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-02-05.19:54:33
Here is review62421003
msg45364 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-12-17.22:09:06
They should be removed because they have no more meaning.
msg45361 (view) Author: [hidden] (Timitos) Date: 2018-12-17.21:31:43
The field base_code, base_sign, tax_code and tax_sign are not computed by the wizard. I think it happend with this changeset[1].

For me it is not clear what needs to be fixed. Either the missing values must be computed or the fields must be removed from the view.

[1] http://hg.tryton.org/modules/account/rev/9135d0ac6abd
History
Date User Action Args
2019-02-13 10:15:11roundup-botsetmessages: + msg46968
2019-02-13 10:15:06roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg46967
2019-02-05 20:06:25reviewbotsetnosy: + reviewbot
messages: + msg46758
2019-02-05 19:54:33cedsetstatus: chatting -> testing
reviews: 62421003
messages: + msg46757
keyword: + review
assignedto: Timitos -> ced
2018-12-20 14:43:10pokolisetkeyword: + easy
2018-12-18 11:16:20Timitossetassignedto: Timitos
2018-12-17 22:09:07cedsetstatus: unread -> chatting
nosy: + ced
messages: + msg45364
2018-12-17 21:31:44Timitoscreate