Tryton - Issues

 

Issue7918

Title negative product cost price for sales and production with UOM less than default
Priority bug Status testing
Superseder Nosy List MR, angel, ced, reviewbot
Type behavior Components product_cost_fifo
Assigned To ced Keywords review
Reviews 251121002
View: 251121002

Created on 2018-12-11.13:29:59 by MR, last changed by reviewbot.

Messages
review251121002 updated at https://codereview.tryton.org/251121002/#ps279071002
msg47541 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2019-03-10.20:04:26
Here is review251121002 which should fix the problem introduced by issue6626.
msg45259 (view) Author: [hidden] (MR) Date: 2018-12-11.13:29:58
Tryton 5.0. If I select UOM less than default ( for example, the product with default UOM in meters I sale in centimeters) for sale or production input, after few sale or production cycles I get negative product cost price in product cost history.
I don't know the coding, but in my opinion the problem is the value move.unit_price attached in product_cost_fifo/move.py function _update_fifo_out_product_cost_price in default UOM and after recalculated in stock/move.py  Move class method _compute_product_cost_price from move UOM to default UOM, it's mean the unit_price is 100 times bigger in my centimeters-meters case
History
Date User Action Args
2019-03-10 20:14:23reviewbotsetnosy: + reviewbot
messages: + msg47542
2019-03-10 20:04:26cedsetstatus: in-progress -> testing
reviews: 251121002
messages: + msg47541
keyword: + review
2019-03-10 19:12:10cedsetstatus: unread -> in-progress
assignedto: ced
type: behavior
component: + product_cost_fifo
nosy: + ced
2019-01-03 16:13:58angelsetnosy: + angel
2018-12-11 13:29:59MRcreate

Showing 10 items. Show all history (warning: this could be VERY long)