Tryton - Issues

 

Issue7833

Title Error with drag and drop to reorder on category tree view.
Priority bug Status resolved
Superseder Nosy List Max452, ced, fmorato, reviewbot, roundup-bot
Type crash Components tryton
Assigned To ced Keywords review
Reviews 48691002
View: 48691002

Created on 2018-11-02.14:22:22 by fmorato, last changed by roundup-bot.

Messages
New changeset 8cabe96afb34 by Cédric Krier in branch '5.0':
Decode JSON selection data
https://hg.tryton.org/tryton/rev/8cabe96afb34
New changeset d9b2c70f4f8e by Cédric Krier in branch 'default':
Decode JSON selection data
https://hg.tryton.org/tryton-env/rev/d9b2c70f4f8e
New changeset e22f72bfb356 by Cédric Krier in branch 'default':
Decode JSON selection data
https://hg.tryton.org/tryton/rev/e22f72bfb356
review48691002 updated at https://codereview.tryton.org/48691002/#ps1
msg45476 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-12-22.18:28:58
Indeed it is only since 3.6 that Python json can loads bytes: https://bugs.python.org/issue17909
msg44720 (view) Author: [hidden] (fmorato) Date: 2018-11-02.14:22:20
Following discussion started on https://discuss.tryton.org/t/reorganization-of-the-sales-line-bug-in-gtk-client/

Python 3.5.3
tryton 5.1.0

On a category tree view, dragging and dropping throws an error.

ERROR:tryton.common.common:  File "tryton/tryton/gui/window/view_form/view/list.py", line 776, in drag_data_received
    data = json.loads(selection_data)
  File "/usr/lib/python3.5/json/__init__.py", line 312, in loads
    s.__class__.__name__))

the JSON object must be str, not 'bytes'
History
Date User Action Args
2019-01-14 19:15:13roundup-botsetmessages: + msg45954
2019-01-05 10:19:42Max452setnosy: + Max452
2019-01-02 19:00:03roundup-botsetmessages: + msg45802
2019-01-02 19:00:01roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg45801
2018-12-22 18:48:03reviewbotsetnosy: + reviewbot
messages: + msg45477
2018-12-22 18:35:35cedsetstatus: in-progress -> testing
reviews: 48691002
keyword: + review
2018-12-22 18:28:58cedsetstatus: unread -> in-progress
assignedto: ced
messages: + msg45476
nosy: + ced
2018-11-02 17:11:16cedsettype: crash
2018-11-02 14:22:22fmoratocreate

Showing 10 items. Show all history (warning: this could be VERY long)