Tryton - Issues

 

Issue7819

Title Add order on shipment moves
Priority feature Status testing
Superseder Nosy List pokoli, reviewbot, uha4
Type feature request Components stock
Assigned To pokoli Keywords review
Reviews 258261002
View: 258261002

Created on 2018-10-26.15:39:02 by uha4, last changed by uha4.

Messages
msg52334 (view) Author: [hidden] (uha4) Date: 2019-10-08.12:06:02
When i was posting this, i was more thinking if this could be solved on a more general basis for all one2many fields. The shipment was just a example.
I was more thinking of making the current order as selected in the client (e.g. by article code ascending) remembered and re-applied after save or reload.
This issue was a direct follow up of https://bugs.tryton.org/issue7818 

I dont have the time and test-enviroment at hand at the moment to test your code. But looking on the code it looks like the user has to add the sequence numbers by hand. Doing so is not easier or faster then hitting ordering button in the table head after every save.
review258261002 updated at https://codereview.tryton.org/258261002/#ps262251002
review258261002 updated at https://codereview.tryton.org/258261002/#ps270281002
msg52325 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-10-07.16:39:38
Here is review258261002 which implements it. I also modified sale and purchase to set the sequence on move, so by default the shipment moves are ordered using the sale/purchase order.
msg52319 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2019-10-07.10:56:09
I think this should be implemented by adding the sequence on the stock move but do not use it as default order and only use this order on the shipment fields. 

This is because I do not think it makes sense to order the Stock Moves view by sequence. I'm not sure which will be the best ordering for this view
msg44607 (view) Author: [hidden] (uha4) Date: 2018-10-26.15:39:01
When you save or reload a record with one2many field, the sort order is lost. 
It would be much more convienient, if the order is preserved when saving, as i have to save everytime before i can e.g. split the moves of a shipment with many lines.
History
Date User Action Args
2019-10-08 12:06:03uha4setmessages: + msg52334
2019-10-07 17:36:22reviewbotsetmessages: + msg52327
2019-10-07 16:40:48reviewbotsetnosy: + reviewbot
messages: + msg52326
2019-10-07 16:39:38pokolisetstatus: chatting -> testing
keyword: + review
messages: + msg52325
reviews: 258261002
assignedto: pokoli
type: behavior -> feature request
2019-10-07 10:56:09pokolisetpriority: wish -> feature
nosy: + pokoli
status: unread -> chatting
messages: + msg52319
2019-09-27 14:41:31cedsettitle: one2many widget: preserve order at reload/save -> Add order on shipment moves
2019-09-24 09:18:14cedsetpriority: feature -> wish
component: + stock, - tryton
2018-10-26 15:39:02uha4create

Showing 10 items. Show all history (warning: this could be VERY long)