Tryton - Issues

 

Issue7791

Title New taxes on account template are not added to account on account chart update
Priority bug Status resolved
Superseder Nosy List Timitos, ced, pokoli, reviewbot, roundup-bot
Type crash Components account
Assigned To Timitos Keywords review
Reviews 72351002,49641002
View: 72351002, 49641002

Created on 2018-10-17.13:46:12 by Timitos, last changed by roundup-bot.

Messages
New changeset 240951d98c46 by Korbinian Preisler in branch '5.0':
Use list of ids in add operation on Many2Many in update_account2
https://hg.tryton.org/modules/account/rev/240951d98c46
New changeset 2f5fa12ceaa8 by C├ędric Krier in branch 'default':
Use list of ids in add operation on Many2Many in update_account2
https://hg.tryton.org/tryton-env/rev/2f5fa12ceaa8
New changeset 89e48591dae1 by Korbinian Preisler in branch 'default':
Use list of ids in add operation on Many2Many in update_account2
https://hg.tryton.org/modules/account/rev/89e48591dae1
msg45002 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-11-25.14:34:14
Also it was a crash because the API for add on one2many requires a list of ids instead of single id.
msg45001 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-11-25.14:31:53
FYI, I tested it (with issue7718) with the test from issue7801 and by upgrading the b2ck database with Belgium taxes which removed many taxes.
msg45000 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-11-25.14:29:56
Following my comments on review49641002, the review72351002 was correct so I will commit it on trunk.
msg44978 (view) Author: [hidden] (Timitos) (Tryton translator) Date: 2018-11-22.16:20:53
For me it is not clear how to proceed with this issue.

I know that first a patch for trunk is needed that can be backported. Should this go into a new review or into one of the existing ones?
msg44491 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-10-20.18:59:33
I've added the test on issue7801 and included a tax on an account to test this scenario.
msg44487 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-10-19.17:09:07
Probably, I propose @pokoli that you move your test in a new issue and include test this case.
msg44486 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-10-19.17:01:36
I'm wondering if we should also test this case on the update_chart of review51561002
review49641002 updated at https://codereview.tryton.org/49641002/#ps20001
msg44483 (view) Author: [hidden] (Timitos) (Tryton translator) Date: 2018-10-19.15:28:19
This is the review for trunk:
review49641002
msg44458 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-10-18.14:01:01
Could you provide a patch for trunk as for me it the higher version affected.
msg44443 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-10-17.15:12:29
OK, the title is not very accurate. Also I do not see why it is a crash? for me, it looks like a behavior issue. Also can you assign and set the status of the issue to you if you are working on it.
msg44441 (view) Author: [hidden] (Timitos) (Tryton translator) Date: 2018-10-17.14:37:21
If you have an account template that does not have taxes set on chart creation. Then you add a tax on this template and then execute the "Update chart of accounts from template" wizard. Then the new tax is not added to the account.
msg44440 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-10-17.13:49:59
I do not understand. What is the problem?
msg44439 (view) Author: [hidden] (Timitos) (Tryton translator) Date: 2018-10-17.13:49:24
This review fixes the problem:
review72351002
msg44438 (view) Author: [hidden] (Timitos) (Tryton translator) Date: 2018-10-17.13:46:11
In at least version 4.8 account taxes of template cannot be copied to account on chart creation.
History
Date User Action Args
2018-12-10 18:53:04roundup-botsetmessages: + msg45235
2018-11-25 14:40:17roundup-botsetmessages: + msg45004
2018-11-25 14:40:10roundup-botsetstatus: in-progress -> resolved
nosy: + roundup-bot
messages: + msg45003
2018-11-25 14:34:14cedsettype: behavior -> crash
messages: + msg45002
2018-11-25 14:31:53cedsetmessages: + msg45001
2018-11-25 14:29:56cedsetmessages: + msg45000
2018-11-25 10:47:49cedlinkissue7801 superseder
2018-11-22 16:20:53Timitossetmessages: + msg44978
2018-10-20 18:59:34pokolisetmessages: + msg44491
2018-10-19 17:09:08cedsetmessages: + msg44487
2018-10-19 17:01:36pokolisetnosy: + pokoli
messages: + msg44486
2018-10-19 16:00:40reviewbotsetnosy: + reviewbot
messages: + msg44484
2018-10-19 15:28:19Timitossetreviews: 72351002 -> 72351002,49641002
messages: + msg44483
2018-10-18 14:01:01cedsetmessages: + msg44458
2018-10-17 15:58:52Timitossettitle: Add action of many2many takes a list of ids in update_account_taxes -> New taxes on account template are not added to account on account chart update
2018-10-17 15:36:40Timitossetstatus: chatting -> in-progress
assignedto: Timitos
2018-10-17 15:36:08Timitossettype: crash -> behavior
2018-10-17 15:12:29cedsetmessages: + msg44443
2018-10-17 14:37:21Timitossetmessages: + msg44441
2018-10-17 13:50:00cedsetnosy: + ced
messages: + msg44440
2018-10-17 13:49:25Timitossetreviews: 72351002
status: unread -> chatting
messages: + msg44439
keyword: + review
2018-10-17 13:46:12Timitoscreate