Tryton - Issues

 

Issue7775

Title Do not fail when not able to connect to SMTP
Priority feature Status resolved
Superseder Nosy List ced, reviewbot, roundup-bot
Type feature request Components trytond
Assigned To ced Keywords review
Reviews 49631002
View: 49631002

Created on 2018-10-08.12:23:44 by ced, last changed by roundup-bot.

Messages
New changeset 92c83e9429ac by Cédric Krier in branch 'default':
Do not fail on SMTP connection error
https://hg.tryton.org/tryton-env/rev/92c83e9429ac
New changeset 98f2056db806 by Cédric Krier in branch 'default':
Do not fail on SMTP connection error
https://hg.tryton.org/trytond/rev/98f2056db806
review49631002 updated at https://codereview.tryton.org/49631002/#ps1
msg44359 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-10-08.12:23:43
We set a default smtp configuration but there are no guarantee that such service is running. get_smtp_server raise an exception if it can not connect to it.
I think we should just log an error and not failed the transaction for that. Email delivery is any way a process without guarantee and we should not stop transactions to happen because there is a email server problem.
History
Date User Action Args
2018-10-15 22:53:09roundup-botsetmessages: + msg44420
2018-10-15 22:53:04roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg44419
2018-10-08 12:31:56reviewbotsetnosy: + reviewbot
messages: + msg44363
2018-10-08 12:25:04cedsetstatus: in-progress -> testing
reviews: 49631002
keyword: + review
2018-10-08 12:23:44cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)