Tryton - Issues

 

Issue7726

Title Do not make contact_mechanism url depend on type
Priority feature Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot
Type feature request Components party
Assigned To pokoli Keywords review
Reviews 45731002
View: 45731002

Created on 2018-09-24.13:36:08 by pokoli, last changed by roundup-bot.

Messages
New changeset 397dc9b2d378 by Sergi Almacellas Abellana in branch 'default':
Show contact mechanism url only when it's defined
https://hg.tryton.org/tryton-env/rev/397dc9b2d378
New changeset 77dc19b2db36 by Sergi Almacellas Abellana in branch 'default':
Show contact mechanism url only when it's defined
https://hg.tryton.org/modules/party/rev/77dc19b2db36
review45731002 updated at https://codereview.tryton.org/45731002/#ps60001
review45731002 updated at https://codereview.tryton.org/45731002/#ps40001
review45731002 updated at https://codereview.tryton.org/45731002/#ps20001
msg44056 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-09-24.14:11:41
Then the getter must be a on_change to work when the type is changed.
review45731002 updated at https://codereview.tryton.org/45731002/#ps1
msg44054 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-09-24.13:36:08
Currently the contact mechanism url visibility is only shown for some types but this makes adding a new types more complex as the visibility has also to be updated. 

I think it will be simpler to only show it if a value is defined, so new types should only need to override the get_url function in order to show the url widget.
History
Date User Action Args
2018-10-15 15:55:36roundup-botsetmessages: + msg44404
2018-10-15 15:54:41roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg44403
2018-10-03 15:26:47reviewbotsetmessages: + msg44298
2018-09-25 14:33:01reviewbotsetmessages: + msg44122
2018-09-25 13:57:33reviewbotsetmessages: + msg44120
2018-09-24 14:11:41cedsetnosy: + ced
messages: + msg44056
2018-09-24 13:54:57reviewbotsetnosy: + reviewbot
messages: + msg44055
2018-09-24 13:38:11pokolisetstatus: in-progress -> testing
reviews: 45731002
keyword: + review
2018-09-24 13:36:08pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)