Tryton - Issues

 

Issue7707

Title Improve behavior of invoice completly paid in statement line
Priority feature Status testing
Superseder Add via on_change does not link to the group
View: 7708
Nosy List ced, coogor, reviewbot
Type feature request Components account_statement
Assigned To ced Keywords review
Reviews 70391002
View: 70391002

Created on 2018-09-18.18:49:24 by ced, last changed by ced.

Messages
msg44640 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-10-27.16:30:05
> Why not issue a message that explains that nothing is to pay?

We are not allowed to raise error message on on_change call. And more over it is bad for the workflow such interruption.
msg44630 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-10-27.13:32:18
I would like to receive some feedback for this proposal.
review70391002 updated at https://codereview.tryton.org/70391002/#ps40001
msg43963 (view) Author: [hidden] (coogor) Date: 2018-09-19.08:31:24
Why not issue a message that explains that nothing is to pay?
review70391002 updated at https://codereview.tryton.org/70391002/#ps20001
review70391002 updated at https://codereview.tryton.org/70391002/#ps1
msg43939 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-09-18.18:49:23
Currently when the user select an invoice on a statement line that is already paid, the invoice field is unset directly. This can astonish the user because he may think its input was not taken.
Instead of this behavior, I propose to behave like when a line overpay an invoice. This means split the line one with zero amount and link to the invoice and the other with the amount and no link. This way the user will understand that his input was taken and there is nothing to pay.
History
Date User Action Args
2018-10-27 16:30:06cedsetmessages: + msg44640
2018-10-27 13:32:18cedsetmessages: + msg44630
2018-10-17 15:06:43reviewbotsetmessages: + msg44442
2018-09-19 08:31:24coogorsetnosy: + coogor
messages: + msg43963
2018-09-18 19:55:48reviewbotsetmessages: + msg43943
2018-09-18 19:29:05reviewbotsetnosy: + reviewbot
messages: + msg43941
2018-09-18 19:28:11cedsetsuperseder: + Add via on_change does not link to the group
2018-09-18 19:23:46cedsetstatus: in-progress -> testing
reviews: 70391002
keyword: + review
2018-09-18 18:49:24cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)