Tryton - Issues

 

Issue7696

Title Add quick shortcut in expr_eval
Priority feature Status resolved
Superseder Nosy List albertca, ced, resteve, reviewbot, roundup-bot
Type performance Components sao, tryton
Assigned To ced Keywords review
Reviews 49571002
View: 49571002

Created on 2018-09-13.17:56:34 by ced, last changed by roundup-bot.

Messages
New changeset f2c3ff22afab by Cédric Krier in branch 'default':
Add quick return when evaluate simple expression
https://hg.tryton.org/tryton-env/rev/f2c3ff22afab
New changeset 0e24843f01b1 by Cédric Krier in branch 'default':
Add quick return when evaluate simple expression
https://hg.tryton.org/tryton/rev/0e24843f01b1
New changeset 94e38eeae5cd by Cédric Krier in branch 'default':
Add quick return when evaluate simple expression
https://hg.tryton.org/sao/rev/94e38eeae5cd
msg43877 (view) Author: [hidden] (albertca) (Tryton committer) (Tryton translator) Date: 2018-09-13.23:07:47
I checked the patch and worked very well (from 53 seconds to <1s)

Backporting it would be great.
review49571002 updated at https://codereview.tryton.org/49571002/#ps1
msg43864 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-09-13.18:02:04
Here is review49571002.
I think it should be back-ported even if it is only a performance issue because as described in issue7695, it makes almost impossible to expand the balance sheet and also because it does not change any API.
msg43862 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-09-13.17:56:33
One cause of issue7695 is that expr_eval make a call to get_eval even for trivial case like empty expression or '[]' or '{}'.
This slow down in an exponential way the computation of the record context for a tree because it calls field.get_context
History
Date User Action Args
2018-09-19 00:14:25roundup-botsetmessages: + msg43950
2018-09-19 00:14:24roundup-botsetmessages: + msg43949
2018-09-19 00:14:18roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg43948
2018-09-14 15:41:04restevesetnosy: + resteve
2018-09-13 23:07:47albertcasetnosy: + albertca
messages: + msg43877
2018-09-13 18:33:38reviewbotsetnosy: + reviewbot
messages: + msg43867
2018-09-13 18:02:04cedsetstatus: in-progress -> testing
reviews: 49571002
messages: + msg43864
keyword: + review
2018-09-13 17:56:43cedlinkissue7695 superseder
2018-09-13 17:56:34cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)