Tryton - Issues

 

Issue7689

Title Manage commissions on sale subscription
Priority feature Status testing
Superseder Nosy List ced, pokoli, reviewbot
Type feature request Components commission
Assigned To pokoli Keywords review
Reviews 70361002
View: 70361002

Created on 2018-09-10.16:27:28 by pokoli, last changed by ced.

Messages
msg43793 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-09-10.17:24:06
On 2018-09-10 17:00, Sergi Almacellas Abellana wrote:
> > I think it is too simple. Commission on subscription can be more complex. For example it could be just one commission on the first iteration or one commission per full year etc.
> 
> Agree but I do not think we should manage all the cases on the base module. 

But I think it should at least support the basis. Commission at the
starting; Commission every invoice; Commission every X time.
And the computation of the amount should also be flexible. It could be
based on the invoice or on the fixed amount etc.

> That's why I included only the base case and leaved other cases for customization modules. 

But for me, this base implementation does not allow customization.

> But if you have any suggestion to improve it, i will be happy to implement it.

I'm pretty sure it should be a kind of commission rule that should be
linked to the subscription instead of directly the plan.
msg43792 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-09-10.17:00:39
> I think it is too simple. Commission on subscription can be more complex. For example it could be just one commission on the first iteration or one commission per full year etc.

Agree but I do not think we should manage all the cases on the base module. 

That's why I included only the base case and leaved other cases for customization modules. 

But if you have any suggestion to improve it, i will be happy to implement it.
msg43791 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-09-10.16:45:13
I think it is too simple. Commission on subscription can be more complex. For example it could be just one commission on the first iteration or one commission per full year etc.
review70361002 updated at https://codereview.tryton.org/70361002/#ps1
msg43789 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-09-10.16:27:27
The commission module adds an optional dependency with the sale module to set the agent on sales. 

It will be useful to have the same optional dependency with the sale_subscription as a recurring sale can also generate commissions to agents or principals.
History
Date User Action Args
2018-09-10 17:24:07cedsetmessages: + msg43793
2018-09-10 17:00:39pokolisetmessages: + msg43792
2018-09-10 16:45:14cedsetnosy: + ced
messages: + msg43791
2018-09-10 16:31:04reviewbotsetnosy: + reviewbot
messages: + msg43790
2018-09-10 16:28:20pokolisetstatus: in-progress -> testing
reviews: 70361002
keyword: + review
2018-09-10 16:27:28pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)