Tryton - Issues

 

Issue7647

Title unsynchronized data due to start_date format
Priority bug Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot, semarie
Type behavior Components account_fr
Assigned To ced Keywords review
Reviews 50581002
View: 50581002

Created on 2018-08-24.14:45:38 by semarie, last changed by roundup-bot.

Messages
New changeset f4147c6dcab6 by Cédric Krier in branch 'default':
Use date instance instead of string for start and end date
https://hg.tryton.org/tryton-env/rev/f4147c6dcab6
New changeset 5c600aa07177 by Cédric Krier in branch 'default':
Use date instance instead of string for start and end date
https://hg.tryton.org/modules/account_fr/rev/5c600aa07177
msg43929 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-09-17.19:45:17
It is a side effect to support json RPC call from external programs that do not manage our PYSON syntax.
review50581002 updated at https://codereview.tryton.org/50581002/#ps1
msg43927 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-09-17.18:49:52
After viewing the review I'm wondering if it won't be better to make the module crash if a date field is defined as string on the xml file.
msg43926 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-09-17.18:41:51
Here is review50581002
msg43054 (view) Author: [hidden] (semarie) Date: 2018-08-24.14:45:38
I noticed some unsynchronized records in Administration / Model / Model / Data from account_fr module, account.tax.template model, that can't be synchronized (error out with "You are not allowed to modify this record. This record is part of the base configuration.")

the `start_date` field is the difference.

for example with `tva_vente_biens_20` id:
- value: [..., ["start_date",{"__class__":"date","year":2014,"month":1,"day":1}], ...]
- value on fs: [..., ["start_date","2014-01-01"], ...]

on IRC, cedk@ told me that "in the XML they are encoded as string but they should be evaluated as date instances"
History
Date User Action Args
2018-09-19 00:13:04roundup-botsetmessages: + msg43947
2018-09-19 00:12:53roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg43946
2018-09-17 19:45:17cedsetmessages: + msg43929
2018-09-17 19:01:24reviewbotsetnosy: + reviewbot
messages: + msg43928
2018-09-17 18:49:53pokolisetnosy: + pokoli
messages: + msg43927
2018-09-17 18:41:52cedsetstatus: unread -> testing
keyword: + review
nosy: + ced
messages: + msg43926
reviews: 50581002
assignedto: ced
type: behavior
2018-08-24 14:45:38semariecreate

Showing 10 items. Show all history (warning: this could be VERY long)