Tryton - Issues

 

Issue7612

Title Add cascading delete on template of tax code line and tax rule line
Priority feature Status testing
Superseder Nosy List ced, reviewbot
Type behavior Components account
Assigned To ced Keywords review
Reviews 48561002
View: 48561002

Created on 2018-08-09.09:28:09 by ced, last changed by ced.

Messages
New review48561002 at https://codereview.tryton.org/48561002/#ps1
msg42813 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-08-09.09:28:09
We do not delete on cascade on the model with template because they are referential data that are used on Many2One so the cascading will fail in most cases. Also we have for most of them date range (see issue7417).
But the line models are a little bit different, they should never be used as referential data. So they can be deleted. And we have no date range on them. So if we need to change the lines, the previous one will stay. So the user will have to manually clean the update.
So for me, it is better to delete on cascade those records.
History
Date User Action Args
2018-08-09 09:32:10cedsetstatus: in-progress -> testing
2018-08-09 09:30:55reviewbotsetnosy: + reviewbot
messages: + msg42815
2018-08-09 09:30:54reviewbotsetreviews: 48561002
keyword: + review
2018-08-09 09:28:09cedcreate

Showing 10 items. Show all history (warning: this could be VERY long)