Tryton - Issues

 

Issue7609

Title Module missing method
Priority bug Status resolved
Superseder Nosy List ced, pokoli, reviewbot, roundup-bot, sashasasha
Type crash Components account_tax_cash
Assigned To pokoli Keywords review
Reviews 45701002
View: 45701002

Created on 2018-08-06.13:27:06 by sashasasha, last changed by roundup-bot.

Files
File name Uploaded Type Edit Remove
Screen Shot 2018-08-06 at 15.06.39.png sashasasha, 2018-08-06.13:27:05 image/png
Messages
New changeset 020daed773f6 by Sergi Almacellas Abellana in branch '4.8':
Replace sum_domain by amount_domain on super method call
https://hg.tryton.org/modules/account_tax_cash/rev/020daed773f6
New changeset 09b97ea630f8 by Sergi Almacellas Abellana in branch 'default':
Replace sum_domain by amount_domain on super method call
https://hg.tryton.org/tryton-env/rev/09b97ea630f8
New changeset cd8113caa846 by Sergi Almacellas Abellana in branch 'default':
Replace sum_domain by amount_domain on super method call
https://hg.tryton.org/modules/account_tax_cash/rev/cd8113caa846
review45701002 updated at https://codereview.tryton.org/45701002/#ps1
msg43050 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-08-23.17:58:54
Here is review45701002 that should fix it.
msg42791 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-08-08.09:43:23
The super call should be to _account_domain instead of _sum_domain

This was wrongly introduced in changeset 08ea1ea4a567

It will be great if you can provide a patch to fix it. 

P.S: Please do not assign issues to others
msg42646 (view) Author: [hidden] (sashasasha) Date: 2018-08-06.13:27:05
Looks like something wrong with 'Account Tax Cash' module which calls super()._sum_domain(). But base 'account.tax' doesn't have the method. 
https://github.com/tryton/account_tax_cash/blob/4.8/account.py#L116
History
Date User Action Args
2018-09-05 22:08:02roundup-botsetmessages: + msg43704
2018-08-27 10:25:26roundup-botsetmessages: + msg43087
2018-08-27 10:25:22roundup-botsetstatus: testing -> resolved
nosy: + roundup-bot
messages: + msg43086
2018-08-23 18:05:41reviewbotsetnosy: + reviewbot
messages: + msg43051
2018-08-23 17:58:55pokolisetstatus: chatting -> testing
reviews: 45701002
messages: + msg43050
keyword: + review
assignedto: pokoli
2018-08-08 09:43:23pokolisetstatus: unread -> chatting
assignedto: ced -> (no value)
messages: + msg42791
nosy: + pokoli
2018-08-06 13:49:02sashasashasetassignedto: ced
nosy: + ced
2018-08-06 13:27:06sashasashacreate