Tryton - Issues

 

Issue7554

Title Allow to customize the type of subdivision used per country
Priority feature Status testing
Superseder Nosy List albertca, ced, pokoli, reviewbot
Type feature request Components party
Assigned To pokoli Keywords review
Reviews 49501002
View: 49501002

Created on 2018-07-02.13:20:11 by pokoli, last changed by reviewbot.

Messages
review49501002 updated at https://codereview.tryton.org/49501002/#ps1
msg42069 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-07-05.13:58:39
Here is review49501002 which implements msg42016
msg42016 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-07-02.15:16:08
I would prefer to not modify the country model but have a specific model, a little bit like the party.address.format. And when nothing is defined for a country, it allows all the types.
msg42015 (view) Author: [hidden] (albertca) (Tryton committer) (Tryton translator) Date: 2018-07-02.14:33:59
> I'm wondering if it won't be better to allow to define on the country model 
> which type of subdivision should be used for address formatting. 
>
> This will ease the user interface by using only one subdivision field and
> always show the data expected by the end user.

That sounds good to me.
msg42014 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-07-02.14:04:50
> I guess we must add a field for a second level of subdivision and update address format to use it when needed.

I'm wondering if it won't be better to allow to define on the country model which type of subdivision should be used for address formatting. 

This will ease the user interface by using only one subdivision field and always show the data expected by the end user.
msg42012 (view) Author: [hidden] (ced) (Tryton committer) (Tryton translator) Date: 2018-07-02.13:54:22
I guess we must add a field for a second level of subdivision and update address format to use it when needed.
msg42009 (view) Author: [hidden] (pokoli) (Tryton committer) (Tryton translator) Date: 2018-07-02.13:20:10
issue5563 restricted the usage of subdivisions without parents on addresses. But this subdivision may not be the most appropriate for the address format introduced by issue5493. This is the case for at least Spain and Italy. On both cases the subdivision is used for address format but it is expected to use the Province type. See: 

http://bitboost.com/ref/international-address-formats/italy/
History
Date User Action Args
2018-07-05 14:15:56reviewbotsetnosy: + reviewbot
messages: + msg42070
2018-07-05 13:58:39pokolisetstatus: chatting -> testing
reviews: 49501002
messages: + msg42069
keyword: + review
assignedto: pokoli
2018-07-02 15:16:08cedsetmessages: + msg42016
2018-07-02 14:33:59albertcasetnosy: + albertca
messages: + msg42015
2018-07-02 14:04:50pokolisetmessages: + msg42014
2018-07-02 13:54:29cedsetcomponent: + party, - country
2018-07-02 13:54:23cedsetnosy: + ced
messages: + msg42012
2018-07-02 13:20:11pokolicreate

Showing 10 items. Show all history (warning: this could be VERY long)